On Sunday 13 July 2008, Per Andersson wrote:
> Thanks for the review!
>
> I believe that everything mentioned in this thread is fixed
> in the new version. [0]
Your hook scripts are not executable:
-rw-r--r-- root/root 45 2008-06-27 22:20
./usr/lib/finish-install.d/70micro-evtd
-rw-r--r-- root/root 46 2008-06-27 22:20
./lib/debian-installer-startup.d/S70micro-evtd
See my comment about that in my first review mail and see qcontrol from
unstable for an example how it can be done correctly (though undoubtedly
there are other methods too).
In "Execute commands here" the "play)" option is missing ";;".
The indentation of ";;" is inconsistent. Personally I always keep it level
with the commands (i.e. +1 tab); you mostly have it level with options,
except for the beep/led/play) options where they are level with commands.
I initially had 'sleep 0.5' in qcontrol too, but it's not supported by
busybox, so you need 'sleep 1'.
Did you run lintian over the finished package?
I think that's it :-)
Cheers,
FJP
Attachment:
signature.asc
Description: This is a digitally signed message part.