On Monday 23 June 2008, Joey Hess wrote: > Frans Pop wrote: > > 0003: Having the two loops looks broken > > In so far that the second loop is likely to copy files that were > > already installed in the first loop. > > If you're referring to the two loops in post-base-installer (and not in Yes, 0003 refers to the patch number. /me thought that'd be obvious :-/ > check-missing-firmware), it's true that the firmware from debs is > copied over a second time after they are installed. I didn't see a good > (simple) way to tell this case from the cases where the firmware in > d-i's /lib/firmware is provided by udebs or as unpackaged files. You may want to at least do them the other way around then: first copy from /lib/firmware, then overwrite with contents from .deb. Or keep the current order, but first check if a file already exists in the second loop (assuming that a certain firmware file has a fixed name). Adding a README with "files added 'manually' by d-i" might be an idea too. Eventually I think we should prefer installing the firmware from a deb in the archive and then only "add" anything from the d-i environment that's not already covered that way.
Description: This is a digitally signed message part.