Re: preliminary patch towards XEN virtual disk naming
On Tue, 2008-04-22 at 11:39 +0200, Ferenc Wagner wrote:
> Ian Campbell <ijc@hellion.org.uk> writes:
>
> > On Sun, 2008-04-20 at 18:56 +0200, Frans Pop wrote:
> >> On Tuesday 08 April 2008, Ian Campbell wrote:
> >> > On Tue, 2008-04-08 at 20:35 +0200, Frans Pop wrote:
> >> > > I would vote for starting the numbering at 1, not 0, as linking 1 to
> >> > > xvda is most natural.
> >> > >
> >> > > One option would be to just
> >> > > use "Virtual disk" in partman (without "Xen" before it). Then parted's
> >> > > description would be a useful further specification of the type of
> >> > > virtual disk.
> >> >
> >> > Both of those sound like reasonable ideas to me.
> >>
> >> Ian or Ferenc: could either of you please submit a final patch based on the
> >> discussions so far (or point me to the one that should be used)?
> >
> > Lets go with this one. It counts the disks from 1 (==xvda) and simply
> > calls it a "Virtual Disk" as suggested this has the advantage of not
> > wrapping in various dialogs too (like the formatting partition one if I
> > remember correctly).
>
> I agree. However, you left out the translation sublevels from the
> templates.
Ah, I suspect I started from a patch other than your most recent one or
something.
> And should we really capitalize Disk?
I think not.
> > I've left any parted enhancements out for now, as you say they would be
> > a useful further specification in the future.
>
> What do you mean here?
The "Unknown" which appears in the dialog comes from parted (I think).
You were looking at adding xvd support to parted and found that a more
recent upstream version already had it, I think. I just meant that the
"Unknown" could become "Xen Virtual disk" in the future adding a bit
more detail to the "Virtual disk" as Frans suggests above (I think,
quoting a bit complex up there ;-)).
>
> > Perhaps it would be useful to name the templates
> > partman/text/virtual_disk_{,partition} or similar to enable sharing
> > under other virtualisation platforms?
>
> That would indeed make sense. What about this patch?
Looks good to me.
Ian.
--
Ian Campbell
Current Noise: Nile - To Dream Of Ur
When you meet a master swordsman,
show him your sword.
When you meet a man who is not a poet,
do not show him your poem.
-- Rinzai, ninth century Zen master
Reply to: