Bug#470951: grub-installer: serial console broken for words!=8 and flow control

To: submit@bugs.debian.org
Subject: Bug#470951: grub-installer: serial console broken for words!=8 and flow control
From: Max Vozeler <max@nusquama.org>
Date: Fri, 14 Mar 2008 19:37:46 +0100
Message-id: <[🔎] 20080314183746.GA17306@dp.vpn.nusquama.org>
Reply-to: Max Vozeler <max@nusquama.org>, 470951@bugs.debian.org

Package: grub-installer
Tags: patch

I was surprised by grub not showing up on the serial 
console after an installation over serial with kernel
option console=ttyS0,11520n8r

The grub menu.lst contained

  serial --unit=1 --speed=115200 --word=r --parity=no --stop=1

But 'r' is an invalid value for word (it takes 5-8).

It turns out the parsing in grub_serial_console() doesn't
handle options strings correctly that specify a word size != 8 
or a flow control parameter (or both).

grub_serial_console() interprets the third character after
the baud rate as value for 'word'. serial-console.txt in 
linux-2.6/Documentation, OTOH, says:

  options:	depend on the driver. For the serial port this
  		defines the baudrate/parity/bits/flow control of
  		the port, in the format BBBBPNF, where BBBB is the
  		speed, P is parity (n/o/e), N is number of bits,
  		and F is flow control ('r' for RTS). Default is
  		9600n8. The maximum baudrate is 115200.

So it should actually take the second character as value 
for word and ignore any third character, because grub doesn't 
seem to offer any option for setting flow control.

The attached patch makes it work for me and fixes both word
and flow control handling. I've checked the results against 
Alex' test script [1], and the results look good to me. 

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=416310#25

	Max

Index: grub-installer/debian/changelog
===================================================================
--- grub-installer/debian/changelog	(Revision 51918)
+++ grub-installer/debian/changelog	(Arbeitskopie)
@@ -9,6 +9,10 @@
   [ Guido Guenther ]
   * Add multipath support modelled after dmraid. Closes: #468832.
 
+  [ Max Vozeler ]
+  * Fix serial console setup for console= options that include either a
+    word size != 8 or a flow control parameter.
+
  -- Guido Guenther <agx@sigxcpu.org>  Mon, 10 Mar 2008 13:29:51 +0100
 
 grub-installer (1.29) unstable; urgency=low
Index: grub-installer/grub-installer
===================================================================
--- grub-installer/grub-installer	(Revision 51918)
+++ grub-installer/grub-installer	(Arbeitskopie)
@@ -53,10 +53,10 @@
 		options=${serconsole##*,}
 	fi
 	local speed=$(echo "$options" | sed -e 's/^\([0-9]*\).*$/\1/')
-	# Take optional 1st (parity) and 3rd (word) characters after speed
+	# Take optional 1st (parity) and 2nd (word) characters after speed
 	options=${options##${speed}}
 	local parity=$(echo $options | sed 's/^\(.\?\).*$/\1/')
-	local word=$(echo $options | sed 's/^.\?.\?\(.\?\).*$/\1/')
+	local word=$(echo $options | sed 's/^.\?\(.\?\).*$/\1/')
 	if [ -z "$speed" ]; then
 		speed="9600"
 	fi

grub_serial_console console=ttyS0
serial --unit=0 --speed=9600 --stop=1
grub_serial_console console=ttyS1
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS0,9600
serial --unit=0 --speed=9600 --stop=1
grub_serial_console console=ttyS0,115200
serial --unit=0 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS1,115200
serial --unit=1 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600n
serial --unit=1 --speed=9600 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n
serial --unit=1 --speed=115200 --parity=no --stop=1
grub_serial_console console=ttyS1,9600e
serial --unit=1 --speed=9600 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e
serial --unit=1 --speed=115200 --parity=even --stop=1
grub_serial_console console=ttyS1,9600o
serial --unit=1 --speed=9600 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o
serial --unit=1 --speed=115200 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600n8
serial --unit=1 --speed=9600 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n8
serial --unit=1 --speed=115200 --parity=no --stop=1
grub_serial_console console=ttyS1,9600n7
serial --unit=1 --speed=9600 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n7
serial --unit=1 --speed=115200 --parity=no --stop=1
grub_serial_console console=ttyS1,9600n8r
serial --unit=1 --speed=9600 --word=r --parity=no --stop=1
grub_serial_console console=ttyS1,115200n8r
serial --unit=1 --speed=115200 --word=r --parity=no --stop=1
grub_serial_console console=ttyS1,9600n7r
serial --unit=1 --speed=9600 --word=r --parity=no --stop=1
grub_serial_console console=ttyS1,115200n7r
serial --unit=1 --speed=115200 --word=r --parity=no --stop=1
grub_serial_console console=ttyS1,9600o8
serial --unit=1 --speed=9600 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o8
serial --unit=1 --speed=115200 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o7
serial --unit=1 --speed=9600 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o7
serial --unit=1 --speed=115200 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o8r
serial --unit=1 --speed=9600 --word=r --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o8r
serial --unit=1 --speed=115200 --word=r --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o7r
serial --unit=1 --speed=9600 --word=r --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o7r
serial --unit=1 --speed=115200 --word=r --parity=odd --stop=1
grub_serial_console console=ttyS1,9600e8
serial --unit=1 --speed=9600 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e8
serial --unit=1 --speed=115200 --parity=even --stop=1
grub_serial_console console=ttyS1,9600e7
serial --unit=1 --speed=9600 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e7
serial --unit=1 --speed=115200 --parity=even --stop=1
grub_serial_console console=ttyS1,9600e8r
serial --unit=1 --speed=9600 --word=r --parity=even --stop=1
grub_serial_console console=ttyS1,115200e8r
serial --unit=1 --speed=115200 --word=r --parity=even --stop=1
grub_serial_console console=ttyS1,9600e7r
serial --unit=1 --speed=9600 --word=r --parity=even --stop=1
grub_serial_console console=ttyS1,115200e7r
serial --unit=1 --speed=115200 --word=r --parity=even --stop=1
================================
The following are invalid inputs but are still handeled
grub_serial_console console=ttyS1,9600X
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS1,115200X
serial --unit=1 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600X8
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS1,115200X7
serial --unit=1 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600X7r
serial --unit=1 --speed=9600 --word=r --stop=1
grub_serial_console console=ttyS1,115200X8r
serial --unit=1 --speed=115200 --word=r --stop=1

grub_serial_console console=ttyS0
serial --unit=0 --speed=9600 --stop=1
grub_serial_console console=ttyS1
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS0,9600
serial --unit=0 --speed=9600 --stop=1
grub_serial_console console=ttyS0,115200
serial --unit=0 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS1,115200
serial --unit=1 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600n
serial --unit=1 --speed=9600 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n
serial --unit=1 --speed=115200 --parity=no --stop=1
grub_serial_console console=ttyS1,9600e
serial --unit=1 --speed=9600 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e
serial --unit=1 --speed=115200 --parity=even --stop=1
grub_serial_console console=ttyS1,9600o
serial --unit=1 --speed=9600 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o
serial --unit=1 --speed=115200 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600n8
serial --unit=1 --speed=9600 --word=8 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n8
serial --unit=1 --speed=115200 --word=8 --parity=no --stop=1
grub_serial_console console=ttyS1,9600n7
serial --unit=1 --speed=9600 --word=7 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n7
serial --unit=1 --speed=115200 --word=7 --parity=no --stop=1
grub_serial_console console=ttyS1,9600n8r
serial --unit=1 --speed=9600 --word=8 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n8r
serial --unit=1 --speed=115200 --word=8 --parity=no --stop=1
grub_serial_console console=ttyS1,9600n7r
serial --unit=1 --speed=9600 --word=7 --parity=no --stop=1
grub_serial_console console=ttyS1,115200n7r
serial --unit=1 --speed=115200 --word=7 --parity=no --stop=1
grub_serial_console console=ttyS1,9600o8
serial --unit=1 --speed=9600 --word=8 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o8
serial --unit=1 --speed=115200 --word=8 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o7
serial --unit=1 --speed=9600 --word=7 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o7
serial --unit=1 --speed=115200 --word=7 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o8r
serial --unit=1 --speed=9600 --word=8 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o8r
serial --unit=1 --speed=115200 --word=8 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600o7r
serial --unit=1 --speed=9600 --word=7 --parity=odd --stop=1
grub_serial_console console=ttyS1,115200o7r
serial --unit=1 --speed=115200 --word=7 --parity=odd --stop=1
grub_serial_console console=ttyS1,9600e8
serial --unit=1 --speed=9600 --word=8 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e8
serial --unit=1 --speed=115200 --word=8 --parity=even --stop=1
grub_serial_console console=ttyS1,9600e7
serial --unit=1 --speed=9600 --word=7 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e7
serial --unit=1 --speed=115200 --word=7 --parity=even --stop=1
grub_serial_console console=ttyS1,9600e8r
serial --unit=1 --speed=9600 --word=8 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e8r
serial --unit=1 --speed=115200 --word=8 --parity=even --stop=1
grub_serial_console console=ttyS1,9600e7r
serial --unit=1 --speed=9600 --word=7 --parity=even --stop=1
grub_serial_console console=ttyS1,115200e7r
serial --unit=1 --speed=115200 --word=7 --parity=even --stop=1
================================
The following are invalid inputs but are still handeled
grub_serial_console console=ttyS1,9600X
serial --unit=1 --speed=9600 --stop=1
grub_serial_console console=ttyS1,115200X
serial --unit=1 --speed=115200 --stop=1
grub_serial_console console=ttyS1,9600X8
serial --unit=1 --speed=9600 --word=8 --stop=1
grub_serial_console console=ttyS1,115200X7
serial --unit=1 --speed=115200 --word=7 --stop=1
grub_serial_console console=ttyS1,9600X7r
serial --unit=1 --speed=9600 --word=7 --stop=1
grub_serial_console console=ttyS1,115200X8r
serial --unit=1 --speed=115200 --word=8 --stop=1

Reply to:

Follow-Ups:
- Bug#470951: marked as done (grub-installer: serial console broken for words!=8 and flow control)
  - From: owner@bugs.debian.org (Debian Bug Tracking System)

Prev by Date: Re: OEM-Install for Debian?
Next by Date: Processed: grub serial bugs
Previous by thread: Re: [Debian-in-workers] Malayalam is missing from Lenny Installer
Next by thread: Bug#470951: marked as done (grub-installer: serial console broken for words!=8 and flow control)
Index(es):
- Date
- Thread