On Thu, Oct 18, 2007 at 07:50:22PM -0400, Joey Hess wrote:
> dann frazier wrote:
> > + # If DHCP provides multiple servers, ignore all but the first
> > + dhcp_ntp=`echo $RET | cut -d' ' -f1`
> Please quote "$RET" here to make it less easy for a rogue NTP server to
> (accidentially) root d-i. :-)
> > Index: dhclient-script
> > ===================================================================
> > --- dhclient-script (revision 49779)
> > +++ dhclient-script (working copy)
> > @@ -89,6 +89,10 @@
> > # Get the domain name into a file suitable for netcfg to read.
> > echo -n "$new_domain_name" > /tmp/domain_name
> > + if [ -n "$new_ntp_servers" ]; then
> > + echo -n "$new_ntp_servers" > /tmp/dhcp-ntp-servers
> > + fi
> I'd probably use printf instead of echo -n although it will work in the
> d-i environment.
OK. Just for my benefit, what's the difference? I assume the 'echo -n'
above my change should get changed as well?
Thanks for your review.