Bug#389881: RC-ness of this bug
- To: Otavio Salvador <otavio@debian.org>, 389881@bugs.debian.org, "Robert Millan [ackstorm]" <rmillan@ackstorm.es>, md@linux.it, debian-release@lists.debian.org
- Subject: Bug#389881: RC-ness of this bug
- From: Colin Watson <cjwatson@debian.org>
- Date: Thu, 8 Mar 2007 11:21:05 +0000
- Message-id: <[🔎] 20070308112105.GB30171@riva.ucam.org>
- Mail-followup-to: Otavio Salvador <otavio@debian.org>, 389881@bugs.debian.org, "Robert Millan [ackstorm]" <rmillan@ackstorm.es>, md@linux.it, debian-release@lists.debian.org
- Reply-to: Colin Watson <cjwatson@debian.org>, 389881@bugs.debian.org
- In-reply-to: <[🔎] 20070307234405.GA5886@hardeman.nu>
- References: <[🔎] 20070306103440.GA7572@acklap03> <[🔎] 20070306121523.GB26900@bongo.bofh.it> <[🔎] 87lkiah780.fsf@neumann.lab.ossystems.com.br> <[🔎] 20070307101109.GA8624@acklap03> <[🔎] 87y7m9cjx0.fsf@ossystems.com.br> <[🔎] 20070307124818.GB13918@acklap03> <[🔎] 87d53lb4by.fsf@ossystems.com.br> <[🔎] 22214.145.64.134.244.1173277099.squirrel@www.hardeman.nu> <[🔎] 20070307234405.GA5886@hardeman.nu>
On Thu, Mar 08, 2007 at 12:44:05AM +0100, David Härdeman wrote:
> I've attached a patch which implements persistent device names in
> partman by checking for devices which are mounted under /target and
> which have a suitable link in /dev/disk/by-id/*
I've attached the Ubuntu patch for the same issue; it's been deployed
for some time and I think it's largely a cleaner approach than fixing it
up post-facto as your patch does. However, I tend to agree with Steve
that doing that at the last minute is risky; we had a fair few little
bits and pieces around the distribution to fix up, IIRC.
--
Colin Watson [cjwatson@debian.org]
diff -Nru /tmp/bRFBYZWEev/partman-target-46/finish.d/fstab_hd_entries /tmp/gRV1OOc9kY/partman-target-46ubuntu2/finish.d/fstab_hd_entries
--- /tmp/bRFBYZWEev/partman-target-46/finish.d/fstab_hd_entries 2006-07-25 23:51:30.000000000 +0100
+++ /tmp/gRV1OOc9kY/partman-target-46ubuntu2/finish.d/fstab_hd_entries 2007-02-15 12:27:59.000000000 +0000
@@ -13,9 +13,18 @@
sort |
while read mp fs type options dump pass; do
case "$fs" in
- (/*)
+ (/dev/disk/*|/dev/fd[0-9]*|/dev/mapper/*|/dev/evms/*|/dev/md[0-9]*)
printf "%-15s %-15s %-7s %-15s %-7s %s\n" "$(mapdevfs $fs)" "${mp}" "$type" "$options" "$dump" "$pass"
;;
+ (/*)
+ uuid="$(PATH="/lib/udev:$PATH" vol_id -u $fs)"
+ if [ "$uuid" ]; then
+ printf "# %s\n" "$(mapdevfs $fs)"
+ printf "%-15s %-15s %-7s %-15s %-7s %s\n" "UUID=$uuid" "${mp}" "$type" "$options" "$dump" "$pass"
+ else
+ printf "%-15s %-15s %-7s %-15s %-7s %s\n" "$(mapdevfs $fs)" "${mp}" "$type" "$options" "$dump" "$pass"
+ fi
+ ;;
esac
done
)
Reply to: