[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#284223: marked as done (discover1: modules with dash in name are not properly handled (patch))



Your message dated Sat, 18 Dec 2004 16:32:14 -0500
with message-id <E1CfmBS-0001Ek-00@newraff.debian.org>
and subject line Bug#284223: fixed in discover1 1.7.6
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 4 Dec 2004 18:02:20 +0000
>From debian.bugs.nospam@zorglub.s.bawue.de Sat Dec 04 10:02:20 2004
Return-path: <debian.bugs.nospam@zorglub.s.bawue.de>
Received: from bender.bawue.de [193.7.176.20] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CaeEe-0006RO-00; Sat, 04 Dec 2004 10:02:20 -0800
Received: from localhost.localdomain (J23b4.j.pppool.de [85.74.35.180])
	by bender.bawue.de (Postfix) with ESMTP
	id 60C4CC40; Sat,  4 Dec 2004 19:02:18 +0100 (MET)
Content-Type: multipart/mixed; boundary="===============1347145296=="
MIME-Version: 1.0
From: Eric Lavarde <debian.bugs.nospam@zorglub.s.bawue.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: discover1: modules with dash in name are not properly handled (patch)
X-Mailer: reportbug 3.2
Date: Sat, 04 Dec 2004 19:04:02 +0100
Message-Id: <[🔎] 20041204180218.60C4CC40@bender.bawue.de>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============1347145296==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: discover1
Version: 1.7.5
Severity: normal


Hi,

when booting, /etc/init.d/discover cuts module names with - before the
minus, so that modprobe thinks it's an option and brings an help
message.
I think the attached patch solves the problem (I can provide more
information, but I think, from the patch, the problem is obvious ;-) ).

Cheers, Eric

-- Package-specific info:
lspci:
0000:00:00.0 0600: 1106:0305 (rev 03)
0000:00:00.0 Host bridge: VIA Technologies, Inc. VT8363/8365 [KT133/KM133] (rev 03)
0000:00:01.0 0604: 1106:8305
0000:00:01.0 PCI bridge: VIA Technologies, Inc. VT8363/8365 [KT133/KM133 AGP]
0000:00:04.0 0601: 1106:0686 (rev 40)
0000:00:04.0 ISA bridge: VIA Technologies, Inc. VT82C686 [Apollo Super South] (rev 40)
0000:00:04.1 0101: 1106:0571 (rev 06)
0000:00:04.1 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06)
0000:00:04.2 0c03: 1106:3038 (rev 16)
0000:00:04.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 16)
0000:00:04.3 0c03: 1106:3038 (rev 16)
0000:00:04.3 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 16)
0000:00:04.4 0680: 1106:3057 (rev 40)
0000:00:04.4 Bridge: VIA Technologies, Inc. VT82C686 [Apollo Super ACPI] (rev 40)
0000:00:09.0 0280: 1048:1000 (rev 02)
0000:00:09.0 Network controller: Elsa AG QuickStep 1000 (rev 02)
0000:00:0a.0 0401: 1274:5880 (rev 02)
0000:00:0a.0 Multimedia audio controller: Ensoniq 5880 AudioPCI (rev 02)
0000:00:0b.0 0100: 1000:000f (rev 26)
0000:00:0b.0 SCSI storage controller: LSI Logic / Symbios Logic 53c875 (rev 26)
0000:00:0c.0 0200: 10ec:8139 (rev 10)
0000:00:0c.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
0000:00:0d.0 0400: 109e:036e (rev 02)
0000:00:0d.0 Multimedia video controller: Brooktree Corporation Bt878 Video Capture (rev 02)
0000:00:0d.1 0480: 109e:0878 (rev 02)
0000:00:0d.1 Multimedia controller: Brooktree Corporation Bt878 Audio Capture (rev 02)
0000:00:11.0 0180: 105a:0d30 (rev 02)
0000:00:11.0 Unknown mass storage controller: Promise Technology, Inc. PDC20265 (FastTrak100 Lite/Ultra100) (rev 02)
0000:01:00.0 0300: 10de:0181 (rev a4)
0000:01:00.0 VGA compatible controller: nVidia Corporation NV18 [GeForce4 MX 440 AGP 8x] (rev a4)

discover:

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.4.27-1-k7
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)

Versions of packages discover1 depends on:
ii  dash                        0.5.1-3      The Debian Almquist Shell
ii  debconf                     1.4.30.10    Debian configuration management sy
ii  discover1-data              1.2004.11.09 hardware lists for libdiscover1
ii  libc6                       2.3.2.ds1-18 GNU C Library: Shared libraries an
ii  libdiscover1                1.7.5        hardware identification library

-- debconf information:
* discover/manage_cdrom_devices: false
  discover/cdrom_base_mountpoint: /media/
  discover/cdrom_base_mountpoint_error:

--===============1347145296==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="discover.diff"

--- discover.ORIG	2004-12-04 18:20:03.000000000 +0100
+++ discover	2004-12-04 18:21:15.000000000 +0100
@@ -156,7 +156,8 @@
         continue
     fi
 
-    MAPPED=$(eval "echo \$map_$MODULE")
+    over=$(echo $arg | sed 's/-/_/g')
+    MAPPED=$(eval "echo \$map_$over")
     if [ -n "$MAPPED" ]; then
         MODULE=$MAPPED
     fi

--===============1347145296==--

---------------------------------------
Received: (at 284223-close) by bugs.debian.org; 18 Dec 2004 21:38:44 +0000
>From katie@ftp-master.debian.org Sat Dec 18 13:38:44 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CfmHj-0005Nb-00; Sat, 18 Dec 2004 13:38:43 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CfmBS-0001Ek-00; Sat, 18 Dec 2004 16:32:14 -0500
From: Joshua Kwan <joshk@triplehelix.org>
To: 284223-close@bugs.debian.org
X-Katie: $Revision: 1.54 $
Subject: Bug#284223: fixed in discover1 1.7.6
Message-Id: <E1CfmBS-0001Ek-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 18 Dec 2004 16:32:14 -0500
Delivered-To: 284223-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: discover1
Source-Version: 1.7.6

We believe that the bug you reported is fixed in the latest version of
discover1, which is due to be installed in the Debian FTP archive:

discover1-udeb_1.7.6_i386.udeb
  to pool/main/d/discover1/discover1-udeb_1.7.6_i386.udeb
discover1_1.7.6.dsc
  to pool/main/d/discover1/discover1_1.7.6.dsc
discover1_1.7.6.tar.gz
  to pool/main/d/discover1/discover1_1.7.6.tar.gz
discover1_1.7.6_i386.deb
  to pool/main/d/discover1/discover1_1.7.6_i386.deb
libdiscover1-dev_1.7.6_i386.deb
  to pool/main/d/discover1/libdiscover1-dev_1.7.6_i386.deb
libdiscover1-pic_1.7.6_i386.deb
  to pool/main/d/discover1/libdiscover1-pic_1.7.6_i386.deb
libdiscover1_1.7.6_i386.deb
  to pool/main/d/discover1/libdiscover1_1.7.6_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 284223@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joshua Kwan <joshk@triplehelix.org> (supplier of updated discover1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 18 Dec 2004 12:33:51 -0800
Source: discover1
Binary: libdiscover1 discover1 libdiscover1-pic discover1-udeb libdiscover1-dev
Architecture: source i386
Version: 1.7.6
Distribution: unstable
Urgency: high
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joshua Kwan <joshk@triplehelix.org>
Description: 
 discover1  - hardware identification system
 discover1-udeb - hardware identification library (udeb) (udeb)
 libdiscover1 - hardware identification library
 libdiscover1-dev - hardware identification library development files
 libdiscover1-pic - hardware identification library - static PIC version
Closes: 284223 285345
Changes: 
 discover1 (1.7.6) unstable; urgency=high
 .
   * Joshua Kwan
     - Apply Eric Lavarde's patch to fix trying to access map variables
       for modules that contain dashes. closes: #284223, #285345
Files: 
 029b2ca0a4c7b3d483dc1b4a27aa5085 1460 admin optional discover1_1.7.6.dsc
 bb92b4d7a37404cdbdd4fb007de3391b 628614 admin optional discover1_1.7.6.tar.gz
 f0580d98c9071e9bad5308b8a86b3225 92644 admin optional discover1_1.7.6_i386.deb
 a0e2f5acccd9528f655ce8c6e7a13f6c 84590 libs optional libdiscover1_1.7.6_i386.deb
 2d7a35fddffa35a3097c1ad9c2a682c6 57690 libdevel optional libdiscover1-dev_1.7.6_i386.deb
 4ea7d4fb74c2eeeae79d98db3e3440b2 56252 libs extra libdiscover1-pic_1.7.6_i386.deb
 0e67a8510cee9ebd859fa057a96994d0 34654 debian-installer extra discover1-udeb_1.7.6_i386.udeb
package-type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: http://triplehelix.org/~joshk/pubkey_gpg.asc

iQIVAwUBQcSeS6OILr94RG8mAQLbOBAAtlGMC9poRKaXSnTmAjD3i0yd4niivsv4
LHc36Hgc3gOmWEZk46hrjlmj4Xm4u9rFvjRpr3rgPL3LvKNlbIJErqeDBF3PpgGT
RytR6K+OrJtQWLDmtMkI4Y6j2vSo7W+g6CvP6l1DsAXkxQAQxfJVs8qyYHWBo5eh
EgeYdk104XRQvpRI5GJbLWPUbiiTDQmEpZvLMVAlvo6TwE0aHV46eRrUTjHPvXfk
vL+XS0R52Rz+K49ZCNrHSnHa7jOg+OAnloxh+5UiRIoOd5Lqp0rSutLFWuqI3a8E
+TSNFoqyUQC0mdMvDUrNY2qvTT9kIpAWYpm4txRiyAaW4udqsAMk5sWYBeUkaeRr
2OWTwVW1zqoyP5/m7ArXdfDh/kcwR1j99G0F4YKsZDmToreMxdtKL8sOnLvzzrvn
29V0v3ZqTIg65uSWDruJ/JYCUhut+JJOfUf1btZaf3ec3k8OwAqIZSxB0CtxqJMo
HXKuv4+qdoH4548m0Y1cAVtyg8j5GohSNYPQJA69ZL9WiZfFOH7Rf4eA6yZ4SFAb
Id/0ezHV+qTUJix8YOTsSh3eQzWVmP2ut9xuX2R5TDrj+Go8RaoOIgRsQprEFLLi
nxZO+m55g2Rfd5mtwxX8Vwiufa1yeSDjg/aPVEuaw/OvzHhgeOyeGxgAfrm1kLQT
ewrHzsfpwgs=
=TK53
-----END PGP SIGNATURE-----



Reply to: