[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: powerpc woody bf installation status



On Thu, May 17, 2001 at 12:47:06AM +0100, Richard Hirst wrote:
> On Mon, May 14, 2001 at 01:51:45PM -0600, Matt Kraai wrote:
> > On Mon, May 14, 2001 at 01:35:20PM -0600, Erik Andersen wrote:
> > > On Mon May 14, 2001 at 05:00:34PM +0100, Richard Hirst wrote:
> > > > Currently using a 0.50 build with the md5sum fix in it, but in that
> > > > sed doesn't work,
> > > > 
> > > > sed -n '/^[Mm][Dd]5[Ss][Uu][Mm]/,/^[^ ]/p' < $reldest
> > > > 
> > > > only spits out the md5sum: line of the release file and none of the
> > > > following lines.  Again, havn't checked cvs yet.
> > > 
> > > Could you send me what $reldest expands to so I can test this
> > > and fix it if needed?
> > 
> > I think that this was bug 91758, which was fixed in 0.51-1.  And I
> > think $reldest expands to one of the Release files, such as
> > http://http.us.debian.org/debian/dists/woody/Release .
> 
> Now using 0.51-4 source, on hppa, and sed still appears to be
> broken.  Now it isn't appending '\n' to its output lines, so all
> output appears as one continuous line:
> 
> Test file:
> =============================== cut ===============================
> Origin: Debian
> Label: Debian
> Suite: testing
> Codename: woody
> Date: Fri, 11 Apr 2001 17:00:00 UTC
> Architectures: hppa
> Components: main
> Description: Debian HPPA Testint distribution - Not Released
> md5sum:
>  e940164e4afe8cd2059629d898efd795               81 main/binary-hppa/Release
>  5942a65bc7c2e735b45a0ced9fa64349            67079 main/binary-hppa/Packages
>  f2932b0670399550fcb878050e007a12            21317 main/binary-hppa/Packages.gz
> =============================== cut ===============================
> 
> richard@slab:~/bin$ cat Release| sed -n '/^[Mm][Dd]5[Ss][Uu][Mm]/,/^[^ ]/p'
> md5sum: e940164e4afe8cd2059629d898efd795               81 main/binary-hppa/Release 5942a65bc7c2e735b45a0ced9fa64349            67079 main/binary-hppa/Packages f2932b0670399550fcb878050e007a12            21317 main/binary-hppa/Packages.gz
> 
> This would appear to be because a call to chomp() has been added
> to sed.c:process_file().

It appears that sed.c was in an indeterminate state when the
sed fix backport occurred.  The appended patch backports some
more fixes and takes care of this problem.  Time for 0.51-5?

Matt

diff -ur busybox-0.51/sed.c busybox-0.51-5/sed.c
--- busybox-0.51/sed.c	Mon May 14 13:12:48 2001
+++ busybox-0.51-5/sed.c	Wed May 16 17:26:24 2001
@@ -577,9 +577,7 @@
 			break;
 	}
 
-	/* if there's anything left of the line, print it */
-	if (*hackline)
-		fputs(hackline, stdout);
+	puts(hackline);
 
 	/* cleanup */
 	free(regmatch);
@@ -594,7 +592,7 @@
 	switch (sed_cmd->cmd) {
 
 		case 'p':
-			fputs(line, stdout);
+			puts(line);
 			break;
 
 		case 'd':



Reply to: