On Sun, Apr 08, 2001 at 04:17:14AM -0400, Adam Di Carlo wrote: > Matt Kraai <kraai@debian.org> writes: > > I believe that this is caused by a bug in libfdisk. It does not > > add hdg to the fdisk_disks list because the device_blocks[] array > > does not contain the proper information for the hdg, hdh, hdi, or > > hdj drives. The device number for hdg is 34 << 8, by using the > > information in device_blocks it is 33 << 8 + 128. Since it isn't > > in this table, it isn't added to the list of drives, hence isn't > > displayed as an option. > > > > The following patch should fix support for hdg and hdh, and add > > support for hdi and hdj (it was already in place for hdk and hdl). > > Is this tested? If so, I'd like to apply it to the stable/potato > branch and merge that to woody? > > OTOH, if it's risky, it should be woody only. Thoughts? It isn't tested. I don't have a computer with that many hard drives. But there are a couple of factors arguing for its inclusion. First, I've confirmed this device information in three places: the kernel's Documentation/devices.txt, /usr/include/linux/major.h, and MAKEDEV. I've also split out the is_drive code and tested that it works when passed the dev_t for /dev/hdg. Finally, even if this code is broken, it would still prevent incorrect disks from being added in is_disk. And since support for hdg appears to be broken already, at the most it could prevent hdh from working as well. Matt
Attachment:
pgp9uhVWRg3kd.pgp
Description: PGP signature