[This is not a formal review with the intent to sponsor, but prospective
sponsors may use these findings as they see fit. Opinions are my own.]
Summary: a missing run-time dependency on fuse needs to be fixed.
[+] The orig.tar.gz is identical to the release file on Github.
[-] Lintian reports a warnings:
- d/rules sets DEB_HOST_ARCH which should not be necessary. Consider
whether this is necessary; if so, add a lintian override or file
a bug against lintian explaining the false positive.
[+] License is GPL-3, licensecheck reports no odd copyrights or licenses
[+] Package builds cleanly with sbuild -d unstable
[+] d/control:
The capitalisation of the synopsis and long description could be improved.
The best practices[1] state that the synopsis gets no starting capital.
(The full description should start with a Capital, but this is awkward as
it starts with the name of the tool.)
1. https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.en.html#bpp-debian-control
Personal opinion:
the last paragraph of the long description is a bit wishy-washy; it could
be put more concisely by stating that the tool offers performance benefits
on large archives with many files.
[+] The rules file fits best practices
[+] passes piuparts [-] tested installation on a clean system There seems to be a missing run-time dependency on fuse: dennis@sidvm:~$ wget https://github.com/google/mount-zip/archive/refs/tags/v1.0.14.zip --2024-05-18 00:30:21-- https://github.com/google/mount-zip/archive/refs/tags/v1.0.14.zip Resolving github.com (github.com)... 140.82.121.3 Connecting to github.com (github.com)|140.82.121.3|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/google/mount-zip/zip/refs/tags/v1.0.14 [following] --2024-05-18 00:30:22-- https://codeload.github.com/google/mount-zip/zip/refs/tags/v1.0.14 Resolving codeload.github.com (codeload.github.com)... 140.82.121.9 Connecting to codeload.github.com (codeload.github.com)|140.82.121.9|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/zip] Saving to: ‘v1.0.14.zip’ v1.0.14.zip [ <=> ] 742.41K 3.31MB/s in 0.2s 2024-05-18 00:30:22 (3.31 MB/s) - ‘v1.0.14.zip’ saved [760225] dennis@sidvm:~$ mount-zip v1.0.14.zip mount-zip: Created mount point 'v1.0.14' fuse: failed to exec fusermount: No such file or directory After installing the fuse package, the program works as expected.
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature