[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059503: RFS: blanket/0.6.0-1 [RFP] -- listen to relaxing sounds



Thank you very much for working on this package. Here are some
recommended improvements:

According to the links in SOUNDS_LICENSING.md :

1. city is CC-BY-3.0

2. white noise is CC-BY-3.0

3. pink noise links to the Spanish wikipedia page. But here's the
English version:
https://en.wikipedia.org/wiki/File:Pink_noise.ogg
which says that the file is licensed as CC-BY-3.0 or
GFDL-1.2-no-invariants-or-later
It technically also allows the option of earlier CC-BY licenses but I
think we may be able to ignore that in our debian/copyright

4. debian/copyright is easier to review if the files are in alphabetical order.

5. Also, you can use the one line license name for the files and then
only include the longer license text once in a separate paragraph to
reduce the length of debian/copyright and improve its readability.
This is mentioned in
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and
there are many examples in existing Debian packages.

6. data/com.rafaelmardojai.Blanket.metainfo.xml* is licensed CC-BY-1.0

7. blanket/mpris.py has several copyright holders that should be
mentioned in debian/copyright

8. I believe you need to add python3-gi to the Depends list so that
Python gobject-introspection works.

9. I suggest adding this to the end of the package description:

 .
 Blanket is a GNOME Circle app.

Thank you,
Jeremy Bícha


Reply to: