Bug#994750: RFS: mazeofgalious/0.63-1 [ITA] -- The Maze of Galious
Control: tags -1 moreinfo
(Just a drive-by-comment..)
On Mon, 1 Nov 2021 19:17:09 +0100 Parodper <parodper@gmail.com> wrote:
> Thank you for reviewing the package, and sorry for any inconveniences.
>
> O 01/11/21 ás 12:51, Bastian Germann escribiu:
> > There is a hint in #341497 why the repackage was done.
>
> Sorry, but I do not see it. I only see a bug report about the game not
> starting, which also happened to me when I removed the non-default sets.
Maybe Bastian meant #341501?
> > I do not see this changed (the links) in your current package.
>
> The current mazeofgalious-data.links for all the graphics/sound sets to
> the default ones. I don't see what needs to be changed.
>
> > Also, some sounds are repacked to silence.
>
> To silence? I did change the sounds missing in the jorito set, but for
> other adjacent ones. It should not be silence.
>
> > Please fix #998229 and use the current download as a base for your
> > package. This also gets rid of build/osx and build/windows.
>
> It seems that the Download version has a debian folder. Would this make
> it a «native» package?
No. Native / non-native is defined differently:
https://wiki.debian.org/DebianMentorsFaq#What_is_the_difference_between_a_native_Debian_package_and_a_non-native_package.3F
Many upstream ships a debian directory (even if it is discouraged.), but that is
making them native.
>
> In any case, the source seems to be the same for both (SVN and Download)
> versions, and this game is not going to have any more development, so I
> don't think this will be a problem.
#998229 is about the d/control Homepage field, not source location...
A watch file is sensible even if upstream ceased development, as this
_might_ change; mentors claims your watch file is broken, so this needs
fixing at least.
> > The #341501 change must be done as a repack (+dfsg), not as a patch.
>
> A few questions on that:
>
> * Should I create the links inside the folders, or leave the
> mazeofgalious-data.links file?
> * What is the syntax for dfsg versions? I can't find it anywhere.
https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds.2BIB0_in_the_version_string_mean.3F
--
tobi
Reply to: