On Sunday, April 22 2018, Elías Alejandro wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "goodvibes"
>
> * Package name : goodvibes
> Version : 0.3.6-1
> Upstream Author : Arnaud Rebillout <elboulangero@gmail.com>
> * URL : http://goodvibes.readthedocs.io/
> * License : GPL-3
> Section : sound
>
> It builds those binary packages:
>
> goodvibes - lightweight internet radio player
>
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/goodvibes
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/g/goodvibes/goodvibes_0.3.6-1.dsc
>
> More information about goodbives can be obtained from
> http://goodvibes.readthedocs.io/
>
> Changes since the last upload:
>
> Initial release (Closes: #890420)
Thanks for the package, Elías. It is quite good, there's just one small
issue that I'd like you to fix before we proceed with the upload.
On d/control, I see you explicitly listed the dependencies ("Depends:"
field). Some of them are OK to be there, but you actually need to
explicitly list these:
Depends:
...
libglib2.0-0 (>= 2.44),
libgtk-3-0 (>= 3.12),
libkeybinder-3.0-0 (>= 0.3),
libsoup2.4-1 (>= 2.42),
...
They'll be automatically picked up when you build the package via the
${shlibs:Depends} variable.
Other than that, the package seems OK. I confess I'm not 100% happy
with the description, but I also couldn't come up with a better one at
the moment, so let's go with this for now.
Please let me know when you address the issue above so we can proceed.
Cheers,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature