Hi Tony,
On Mon, Jul 6, 2015 at 8:25 AM, Tony Houghton <h@realh.co.uk> wrote:
> On 04/07/15 22:29, Vincent Cheng wrote:
>
>> (If you have time, please upload an updated package to mentors so it's
>> easier to discuss any further changes.)
>
>
> I've done that, hopefully it will be available by the time you read
> this. The Breaks/Replaces I've decided on are as follows:
>
> Package: roxterm-data
> Replaces: roxterm-common
> Breaks: roxterm-common (<< 3.0.0)
>
> I don't think it needs to explicitly Break any other packages,
> because their removal/replacement will be forced along with
> roxterm-common.
>
> Package: roxterm
> Replaces: roxterm-gtk3 (<< 3.0.0), roxterm-gtk2 (<< 3.0.0)
> Breaks: roxterm-gtk3 (<< 3.0.0), roxterm-gtk2 (<< 3.0.0)
>
> I originally also had it Break the old -dbg packages, but I think
> that's superfluous for the same reason as above.
>
> Package: roxterm-dbg
> Replaces: roxterm-gtk3-dbg (<< 3.0.0), roxterm-gtk2-dbg (<< 3.0.0)
> Breaks: roxterm-gtk3-dbg (<< 3.0.0), roxterm-gtk2-dbg (<< 3.0.0)
>
>
> roxterm-gtk2, roxterm-gtk3, roxterm-gtk2 and roxterm-gtk3 are now all
> dummy packages, they don't Break or Replace anything because the
> packages they depend on should take care of everything, and as virtual
> packages they don't contain files that clash with others.
>
> Nothing explicitly breaks the old virtual package roxterm, I can't see a
> need for that with all the other relationships I have.
>
> I've tested what should be the most difficult upgrade scenario in the
> piuparts chroot and it went smoothly.
>
> Other changes:
>
> I think debian/rules was passing CFLAGS etc to ./mscript.py configure
> incorrectly so I've fixed that.
>
> During testing I had a problem with changes wrt the tarball in a pot
> file while trying to repeat a build so I've added a
> debian/source/options with extend-diff-ignore for .pot and .po.
Your changes all look good to me (and I imagine working on d/control
and testing your changes must have been tedious, thanks for sticking
it out!), but your package FTBFS for me in an up-to-date pbuilder sid
chroot:
make[0]: Entering directory "/tmp/buildd/roxterm-3.0.1/debian/build/po"
/usr/bin/msgmerge -q -U /tmp/buildd/roxterm-3.0.1/po/pt_BR.po
/tmp/buildd/roxterm-3.0.1/po/roxterm.pot
Internal function: touch(['/tmp/buildd/roxterm-3.0.1/po/pt_BR.po'],
['/tmp/buildd/roxterm-3.0.1/po/roxterm.pot'])
Traceback (most recent call last):
File "/tmp/buildd/roxterm-3.0.1/maitch.py", line 3037, in run
job.run()
File "/tmp/buildd/roxterm-3.0.1/maitch.py", line 1622, in run
self.__inner_run()
File "/tmp/buildd/roxterm-3.0.1/maitch.py", line 1713, in __inner_run
for l in f.readlines():
File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
836: ordinal not in range(128)
debian/rules:36: recipe for target 'override_dh_auto_build' failed
I've attached the full build log.
Regards,
Vincent
Attachment:
roxterm_3.0.1-1_amd64.build
Description: Binary data