[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748613: RFS: gimagereader/2.93-1 [ITP]



Hi Philip,

In gimagereader, please:

1. Fix this Linitian message: desktop-entry-lacks-keywords-entry

2. Create a VCS to control your /debian versions. You can use github
or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control.

3. d/control: please, in long description, put one or two lines
explaining what is tesseract. Use punctuation in phrases.

4. d/copyright:

     - Change from  '2009-2013, Canonical Ltd' to 'Copyright (C)
2009-2013 Canonical Ltd., by Robert Ancell
<robert.ancell@canonical.com>'.
     - Use GPL-3+ in debian/*. Your package is a derivative work and
GPL3 is incompatible with GPL2. [1]
     - You need write the license using the FSF rules [2]. An example here[3].


[1] http://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility
[2] http://www.gnu.org/licenses/gpl-howto.html
[3] http://metadata.ftp-master.debian.org/changelogs/main/g/gconjugue/unstable_copyright

5. d/docs: you must install the documents that are useful to final
users. So, remove AUTHORS. It must be put in d/copyright only.

6. d/rules:
    - Comment the verbose line.
    - Add 'export V=1' to show all compiler flags. If you want read
about it, $ man blhc.

The lintian shows a message about hardening. But, for the first time
in my life, i think that it is a false positive. The flags are in
Makefile and 'blhc --all' doesn't show warnings.

7. d/watch: to allow downloads, point to 'releases' instead 'tags'.

Thanks for your work.

Cheers,

Eriberto




2014-08-18 13:45 GMT-03:00 Philip Rinn <rinni@inventati.org>:
> Hi Eriberto,
>
> thanks for looking at my package. I added a man page now and corrected the
> capitalization error in description. I use hardening build flags but I don't know
> why no fortified libc functions are used - do you have an idea?
>
> If you want to review my package you also need gtkspellmm[1] for which I'm waiting
> for a review to get it sponsored.
>
> Thanks for your effort.
>
> Best,
> Philip
>
> [1] http://mentors.debian.net/package/gtkspellmm
>
>
> On 18.08.2014 16:23, Eriberto Mota wrote:
>> tags 748613 moreinfo
>> thanks
>>
>>
>> Hi Philip,
>>
>> I saw your package in mentors.debian.org and it has some Lintian messages.
>>
>> IMHO, to get a sponsor you must, at least, clear your package removing
>> all possible messages.
>>
>> PS: to improve your Lintian, please, see http://bit.ly/lintian
>>
>> Regards,
>>
>> Eriberto
>
>


Reply to: