[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#950776: marked as done ("Took 213503982334601d 7h 0min 15s" due to typo bug inftparchive/apt-ftparchive.cc)



Your message dated Tue, 18 Feb 2020 11:49:47 +0000
with message-id <E1j41Nr-0007yw-Pf@fasolo.debian.org>
and subject line Bug#950776: fixed in apt 1.9.10
has caused the Debian Bug report #950776,
regarding "Took 213503982334601d 7h 0min 15s" due to typo bug inftparchive/apt-ftparchive.cc
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
950776: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950776
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: apt-utils
Version: 1.8.2
Severity: minor
File: /usr/bin/apt-ftparchive
Tags: patch

I'm pretty sure this is a simple typo:

    diff --git a/ftparchive/apt-ftparchive.cc b/ftparchive/apt-ftparchive.cc
    index 077701c..51d492c 100644
    --- a/ftparchive/apt-ftparchive.cc
    +++ b/ftparchive/apt-ftparchive.cc
    @@ -973,7 +973,7 @@ static bool Generate(CommandLine &CmdL)
        struct timeval NewTime = GetTimevalFromSteadyClock();
        std::chrono::duration<double> Delta =
           std::chrono::seconds(NewTime.tv_sec - StartTime.tv_sec) +
    -      std::chrono::microseconds(NewTime.tv_sec - StartTime.tv_usec);
    +      std::chrono::microseconds(NewTime.tv_usec - StartTime.tv_usec);
        c1out << "Done. " << SizeToStr(Stats.Bytes) << "B in " << Stats.Packages
              << " archives. Took " << TimeToStr(llround(Delta.count())) << endl;

Without that patch, "apt-ftparchive generate /dev/null" often returns a very large "Took Ad Bh Cmin Ds" instead of "Took 0s".
With this patch, I seem to get "Took 0s" consistently.

AFAICT this landed in

    79b61ae 2018-05-26 17:36 +0200 DKa ∙ Use a steady clock source for progress reporting

and it still present in git master (1.9.9).

PS: I just noticed my patch only fixed ONE instance of this code, but it's copy-pasted into several places, so all of them need fixing.

-- System Information:
Debian Release: 10.2
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-0.bpo.2-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages apt-utils depends on:
ii  apt             1.8.2
ii  libapt-inst2.0  1.8.2
ii  libapt-pkg5.0   1.8.2
ii  libc6           2.29-9
ii  libdb5.3        5.3.28+dfsg1-0.5
ii  libgcc1         1:8.3.0-6
ii  libstdc++6      9.2.1-23

apt-utils recommends no packages.

apt-utils suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: apt
Source-Version: 1.9.10
Done: Julian Andres Klode <jak@debian.org>

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 950776@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julian Andres Klode <jak@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Feb 2020 12:32:42 +0100
Source: apt
Architecture: source
Version: 1.9.10
Distribution: experimental
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Julian Andres Klode <jak@debian.org>
Closes: 950776 951012
Changes:
 apt (1.9.10) experimental; urgency=medium
 .
   [ David Kalnischkies ]
   * Fix remaining usec vs sec time-delta calculation typos.
     Thanks to Trent W. Buck for initial patch (Closes: #950776)
 .
   [ Julian Andres Klode ]
   * seccomp: Allow time64 variants (>402,<415) of allowed syscalls
     (Closes: #951012)
   * debian/control: Bump libseccomp-dev Build-Depends to >= 2.4.2
   * seccomp: Allow recvmmsg_time64() and futex_time64()
   * policy: Add SetPriority() methods
   * Revert "Add a Packages-Require-Authorization Release file field"
 .
   [ Michael Vogt ]
   * doc: remove "WIP" from apt.8.xml
Checksums-Sha1:
 9a28a486a81f2c73ad207b3a7d56ca95ec7831ca 2762 apt_1.9.10.dsc
 47c5822194aac41c822cc9b5f18ebc36664f93cc 2179100 apt_1.9.10.tar.xz
 3026eca14846f096ea6087b765609fb82fed2645 7382 apt_1.9.10_source.buildinfo
Checksums-Sha256:
 40d95d8e4db192684143e4d76208ea0e38f08e0f24c03c621ff8a2b6fc11916c 2762 apt_1.9.10.dsc
 43cb8a6125063103700d66a2e24fd9d78ea42c1d113f11795abe05d89985aa24 2179100 apt_1.9.10.tar.xz
 df97b5f319c9e86946a9d3b3de4cc38327255630334f4c863378329be95feebe 7382 apt_1.9.10_source.buildinfo
Files:
 bbc9978f7e8e0b1cd9dded01fe0dc1a4 2762 admin important apt_1.9.10.dsc
 632c047099bc1bbbad93d84b5e0ac6f9 2179100 admin important apt_1.9.10.tar.xz
 bafecac86179461d7ec1c7d63d0a7b8c 7382 admin important apt_1.9.10_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEET7WIqEwt3nmnTHeHb6RY3R2wP3EFAl5Ly6UPHGpha0BkZWJp
YW4ub3JnAAoJEG+kWN0dsD9xxY0P/RtdUWHnVs3PVRBQuu5bKz1uP0iCvzwrGxv3
ArkllOpgVfFwwv/bw74z2JwSMgUlLJfsRUxG/TIFsL67h+fNlDUJOz9G9MiTxhqk
obv4OCaXSZ60T+G4bLA1aSY5WTKiWMQe89HHgXghlZUNgDinJqViLiw5zNhuuHWp
JIwLiNVtbhNIKaeCvszoBxumnWis0ne4ACKjlMKxnwNgrgzHsOHWbYAcz6scAQ2U
x0L64YI/CCgRsWuAtwzomVKy0I1D667nyXzufYjFiv43m7cH0elBrhS/ZIagi60q
QIR6dy48oCAwdmlJreOND7GfjC3cSHLdRxwUgOJIcMyrUB1qqNHKlsomFsCeMoHE
Ulv02DZXcm8XTL/+z011KUJgZE1jAVtuL1DO3NhAVj5Clqaag3Q9FZLR+nendXzE
lJ0RcpkaWguns8jfgzCk9vjzRKKcAQu+olApeASotxrkQ6igPEXZzmIXJLxEXKvc
4s8+AogSdbUTSWrp1vvGxU3p5Y+UPcNl51p8uSYIyU/IqVrQsFxGifVeksh1j+1K
rYjMuA8wftQY9awr2WfxZZ7Dm/h4iTSGbMKdgp8ajTXOtyGEBtK68oCoTIqTXFgA
lY1BfPCFIVfXMY+4GQQAx568MRJqdgIwxOBWyDhZ4RuzeBgSfkAB0ZRKQBJCAcTs
dc3OUhu6
=KpOb
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: