Bug#692018: xfdesktop4: Possible memory leak in settings/main.c
Control: tags -1 fixed-upstream
I know it's been a long time but it looks like commit
26b9e349bc3497922318bbc5940075d0c497cc8a fixed it by calling
g_free(pdata) before returning from
image_treeview_drag_data_received():
@ -1172,14 +1175,15 @@ image_treeview_drag_data_received(GtkWidget *widget,
pdata->model = g_object_ref(G_OBJECT(model));
if(TARGET_TEXT_URI_LIST != info
- || selection_data->format != 8
- || selection_data->length <= 0)
+ || gtk_selection_data_get_format(selection_data) != 8
+ || gtk_selection_data_get_length(selection_data) <= 0)
{
gtk_drag_finish(context, FALSE, FALSE, time_);
+ g_free(pdata);
return;
}
- p = (gchar *)selection_data->data;
+ p = (gchar *)gtk_selection_data_get_data(selection_data);
while(*p) {
if(*p != '#') {
gchar *q;
It doesn't matter anyway because the whole function was dropped in
commit 88a920697b22b0653f244ede15f8e645ae013139. Do you think it's
reasonable to close this bug?
Reply to: