[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1029503: marked as done (spirv-cross: new upstream release breaks API)

Your message dated Mon, 30 Jan 2023 15:00:03 +0100
with message-id <20230130140003.oyt2tb2gkqnkmit4@mail.gaussglocke.de>
and subject line Re: Bug#1029503: Last upload of spirv-cross breaks API
has caused the Debian Bug report #1029503,
regarding spirv-cross: new upstream release breaks API
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1029503: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029503
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: spirv-cross
Version: 2021.01.15+1.3.236.0-1
Severity: serious
Tags: ftbfs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Dear co-maintainers,

the recent upload of spirv-cross 2021.01.15+1.3.236.0-1 has incompatible
API changes which break reverse dependencies, notably src:filament.

This type of change is no longer appropriate since the 2023-01-12 transition freeze.
Please keep this bug at a RC-critical severity to prevent migration to
testing.


Relevant excerpt from a filament rebuild:

[...]
[ 50%] Built target test_utils
/<<PKGBUILDDIR>>/libs/filamat/src/GLSLPostProcessor.cpp:349:75: error: too few arguments to function call, expected 3, have 2
                glslCompiler.remap_ext_framebuffer_fetch(i.first, i.second);
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  ^
/usr/include/spirv_cross/spirv_glsl.hpp:203:7: note: 'remap_ext_framebuffer_fetch' declared here
        void remap_ext_framebuffer_fetch(uint32_t input_attachment_index, uint32_t color_location, bool coherent);
             ^
1 error generated.
make[3]: *** [libs/filamat/CMakeFiles/filamat.dir/build.make:331: libs/filamat/CMakeFiles/filamat.dir/src/GLSLPostProcessor.cpp.o] Error 1
[...]


Cheers
Timo


-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEJvtDgpxjkjCIVtam+C8H+466LVkFAmPOhI8ACgkQ+C8H+466
LVmO/QwAnyuW2b78PW1dGWP/S0uOn10R4Khg1vtayd6dG+d4DItcDYtiXQcB4p4a
1f9zJwnkB3PT2nvpXT29frqvOO9rz4JQ/fT68bEpjluRL3255MNRTjseTSiZRIFA
rBkmyflC1+5agaJhuQSH4FR7PkuSpnCKA4uTAuvQf4gYQEmeUGb8Exca2YKXVeK1
8iPTIDyvd8LUVJBhnp0O7d8j1XJXibzewuyEzivGoTGbNJ+PVoeBLSxx1BzOKT5C
2QEpy6Ji9tG9UIzm7AjqNdTwnQOejSXKWthQsyFx4QAgoIOv+ppv2PpZiQWSzgFY
CVy8ngQdS2k1uwCokAFperRS9XuoUT0EaR43jALpZ1ryfmSzmZrkGDMyZXaUFV9l
ubYMQpp/JBe9YfMV6M02kV45ihbXqHSUdK9QrwVnWGLZIwnoeLJbs+K0Jm/jpfY+
Qq7pVAtEt2Kr+LU0xkssuskKbyMeFvkLJcAXFJ3vI55/e8XgaiHMUJuwzzbnH9aj
NOfNqANT
=/4Kr
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message --- 
Control: notfound -1 spirv-cross/2021.01.15+1.3.236.0-1

Hi,

* Sebastian Ramacher <sramacher@debian.org> [2023-01-27 23:55]:

Now, the question is what should I do because of the freeze? Should I
somehow revert my upload with a new
`2021.01.15+1.3.236.0+real2021.01.15` version? Should I fix filament
or should I keep
the RC #1029503 open against the new version of spirv-cross?


Both is acceptable at this stage of the freeze.

I have uploaded a fixed version of filament and will close this bug
now to let both filament and spirv-cross migrate to testing.


Cheers
Timo

--
⢀⣴⠾⠻⢶⣦⠀   ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁   │ Timo Röhling                                       │
⢿⡄⠘⠷⠚⠋⠀   │ 9B03 EBB9 8300 DF97 C2B1  23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀   ╰────────────────────────────────────────────────────╯

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: