Bug#995809: libinput: please make the build reproducible

["Chris Lamb" <lamby@debian.org>]

Source: libinput
Version: 1.19.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
libinput could not be built reproducibly.

This is due to the use of the LIBINPUT_QUIRKS_DIR macro which includes
the absolute build path.

It is not entirely clear (during a very brief look) when/where this
value is even used — the testsuite still passes even if this is set to
a dummy value (see attached dummy patch). And, of course, the build
path cannot be relied upon at runtime.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/0001-reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/0001-reproducible-build.patch	2021-10-06 10:05:03.555141278 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2021-10-06
+
+--- libinput-1.19.1.orig/meson.build
++++ libinput-1.19.1/meson.build
+@@ -13,7 +13,7 @@ dir_libexec     = get_option('prefix') /
+ dir_lib         = get_option('prefix') / get_option('libdir')
+ dir_man1        = get_option('prefix') / get_option('mandir') / 'man1'
+ dir_system_udev = get_option('prefix') / 'lib' / 'udev'
+-dir_src_quirks  = meson.current_source_dir() / 'quirks'
++dir_src_quirks  = '/nonexistent'
+ dir_src_test    = meson.current_source_dir() / 'test'
+ dir_src         = meson.current_source_dir() / 'src'
+ 
--- a/debian/patches/series	2021-10-06 09:35:40.889907597 +0100
--- b/debian/patches/series	2021-10-06 10:00:57.178902346 +0100
@@ -1 +1,2 @@
 #placeholder
+0001-reproducible-build.patch