On 11/17/20 4:41 PM, Santiago Ruano Rincón wrote: > El 09/11/20 a las 13:31, Jakub Ružička escribió: >> Package: wnpp >> Severity: wishlist >> Owner: Jakub Ružička <jakub.ruzicka@nic.cz> >> >> * Package name : lua-binaryheap >> Version : 0.4 >> Upstream Author : Thijs Schreijer <thijs@thijsschreijer.nl> >> * URL : https://github.com/Tieske/binaryheap.lua >> * License : MIT >> Programming Lang: lua >> Description : binary heap implementation in lua >> >> binaryheap.lua is a binary heap (binary tree) implementaion in lua. >> > ... > > Jakub, thanks for packaging lua-binaryheap. Thanks for fast respone, Santiago :) > > Two lintian "major" comments from your current repo: > > W: lua-binaryheap source: ancient-standards-version 3.9.8 (released 2016-04-06) (current is 4.5.0) > W: lua-binaryheap source: package-uses-deprecated-debhelper-compat-version 9 > > Do you have any reason for that standards-version and > debhelper-compat-version? Upstream packages support older distros including ubuntu xenial so it's just a leftover - I've updated these to current. > > These other lintian minor warnings could be easily fixed: > > I: lua-binaryheap: capitalization-error-in-description lua Lua > I: lua-binaryheap source: debian-watch-file-is-missing > I: lua-binaryheap source: vcs-field-not-canonical Vcs-Git > > Could you please consider them? I've fixed all of them except debian-watch-file-is-missing because upstream is using one the weirdest version tag scheme I've witnessed (version_0v4) and I'm not familiar with watch files enough to solve this efficiently. I've pushed fixed debian/master and you can see lintian output in CI: https://salsa.debian.org/jruzicka/lua-binaryheap/-/jobs/1176088#L27 Thank you for Salsa CI suggestion and help with enabling it. I like it and I'll probably use it for other packages too. Cheers, Jakub
Attachment:
signature.asc
Description: OpenPGP digital signature