Bug#1057835: openssh-client: Suggested ssh-keygen on HostId error uses double quotes, incompatible with rc/es

[James Haggerty <james.haggerty@gmail.com>]

Package: openssh-client
Version: 1:9.2p1-2+deb12u1
Severity: normal
X-Debbugs-Cc: james.haggerty@gmail.com

Dear Maintainer,

Debian is carrying a patch (mention-ssh-keygen-on-keychange.patch) that
suggests using ssh-keygen to remove keys on check_host_key errors.
Unfortunately, the suggested command uses single quotes rather than double
quotes. For most shells this is fine, but rc (and rc inspired shells like es) use
only single quotes.

Since single quotes would be preferable even for Bourne shell derivatives,
as no special parsing should be applied to the options, it would be great
if this patch could have the double quotes changed to single quotes.

i.e.
+               error("  ssh-keygen -f \"%s\" -R \"%s\"", 
would be
+               error("  ssh-keygen -f '%s' -R '%s'", 


-- System Information:
Debian Release: 12.2
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-0.deb12.1-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages openssh-client depends on:
ii  adduser           3.134
ii  libc6             2.36-9+deb12u3
ii  libedit2          3.1-20221030-2
ii  libfido2-1        1.12.0-2+b1
ii  libgssapi-krb5-2  1.20.1-2+deb12u1
ii  libselinux1       3.4-1+b6
ii  libssl3           3.0.11-1~deb12u2
ii  passwd            1:4.13+dfsg1-1+b1
ii  zlib1g            1:1.2.13.dfsg-1

Versions of packages openssh-client recommends:
ii  xauth  1:1.1.2-1

Versions of packages openssh-client suggests:
pn  keychain      <none>
pn  libpam-ssh    <none>
pn  monkeysphere  <none>
pn  ssh-askpass   <none>

-- no debconf information