Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success
- To: 778913@bugs.debian.org
- Subject: Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success
- From: Michael Biebl <biebl@debian.org>
- Date: Thu, 10 Sep 2015 18:13:24 +0200
- Message-id: <[🔎] 55F1AC24.8000704@debian.org>
- Reply-to: Michael Biebl <biebl@debian.org>, 778913@bugs.debian.org
- In-reply-to: <5552686C.3070706@debian.org>
- References: <20150221180856.12090.48131.reportbug@heisenberg.scientia.net> <20150222114626.GO3020@riva.ucam.org> <1424624968.7188.2.camel@scientia.net> <20150222175306.GP3020@riva.ucam.org> <87k2z9rdih.fsf@hope.eyrie.org> <55188827.3000708@debian.org> <1427680921.4878.49.camel@scientia.net> <1427680921.4878.49.camel@scientia.net> <5551E7C6.8030303@debian.org> <55521741.3080004@debian.org> <55521F76.9000906@debian.org> <5552686C.3070706@debian.org> <5552686C.3070706@debian.org>
Hi Colin!
On Tue, 12 May 2015 22:54:04 +0200 Michael Biebl <biebl@debian.org> wrote:
> Am 12.05.2015 um 17:42 schrieb Michael Biebl:
> > Am 12.05.2015 um 17:07 schrieb Michael Biebl:
>
> >> As you can see, systemd tries to repeatedly start the service until it hits
> >> start-limit.
> >> We should use sd_notify in that case to pass a correct error code to systemd.
> >
> > Or we could use what's been proposed by Colin, i.e.
> > ExecStartPre=/usr/bin/sshd -t
> > or my
> > RestartPreventExitStatus=255
>
> Updated patch, adding RestartPreventExitStatus=, attached.
>
> From my limited testing, seems to work fine here.
Now that jessie is out the door, it would be a great time to apply this
patch and solve this issue for good.
Did you have time for a review yet?
Cheers,
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature
Reply to: