Bug#782857: snapshot.debian.org: API returns incorrect / multiple filenames when one source has been uploaded with multiple names

[Stefano Rivera <stefanor@debian.org>]

Package: snapshot.debian.org
Severity: normal
Control: affects -1 devscripts

Don't know if this is a duplicate of some of the similar bugs in the
BTS. But I ran into some missing orig tarballs in the DPMT svn->git migration.
The cause seems to be multiple orig tarballs, with the same hash, in the DB.
The debsnap tool doesn't write the resulting file to the correct filename, for unpacking the .dsc.

I don't really know if the fault here is client or server side, it looks like a
bit of both.

The packages I ran into:
python-django 1.0~beta2-2
pyfribidi 0.6.0-4
ldaptor 0.0.43-1

This python-django upload has the wrong orig tarball filename:
curl 'http://snapshot.debian.org/mr/package/python-dango//1.0~beta2-2/srcfiles?fileinfo=1' | jq .

{
  "_comment": "foo",
  "version": "1.0~beta2-2",
  "result": [
    {
      "hash": "bd6f70d19abebe75444547f38c8c5b1bfc490141"
    },
    {
      "hash": "9105b68ae9b755cf8010f340a3eeb136676d6df9"
    },
    {
      "hash": "1a63a98988f7753ac45932b5fece90e26ad8f6d3"
    }
  ],
  "fileinfo": {
    "9105b68ae9b755cf8010f340a3eeb136676d6df9": [
      {
        "name": "python-django_1.0~beta2+ds.orig.tar.gz",
        "archive_name": "debian",
        "path": "/pool/main/p/python-django",
        "first_seen": "20080831T000000Z",
        "size": 4687454
      }
    ],
    "1a63a98988f7753ac45932b5fece90e26ad8f6d3": [
      {
        "name": "python-django_1.0~beta2-2.diff.gz",
        "archive_name": "debian",
        "path": "/pool/main/p/python-django",
        "first_seen": "20080830T000000Z",
        "size": 8728
      }
    ],
    "bd6f70d19abebe75444547f38c8c5b1bfc490141": [
      {
        "name": "python-django_1.0~beta2-2.dsc",
        "archive_name": "debian",
        "path": "/pool/main/p/python-django",
        "first_seen": "20080830T000000Z",
        "size": 1527
      }
    ]
  },
  "package": "python-django"
}

This one has multiple orig tar filenames, and debsnap doesn't write to the one it needs to:
curl 'http://snapshot.debian.org/mr/package/pyfribidi/0.6.0-4/srcfiles?fileinfo=1' | jq .
...
    "e24d8757db3496f44fb05ac3eb4a62c646b4c06e": [
      {
        "name": "pyfribidi_0.6.orig.tar.gz",
        "archive_name": "debian",
        "path": "/pool/main/p/pyfribidi",
        "first_seen": "20060131T000000Z",
        "size": 92793
      },
      {
        "name": "pyfribidi_0.6.0.orig.tar.gz",
        "archive_name": "debian",
        "path": "/pool/main/p/pyfribidi",
        "first_seen": "20080204T000000Z",
        "size": 92793
      },
      {
        "name": "pyfribidi_0.6.orig.tar.gz",
        "archive_name": "debian-archive",
        "path": "/debian/pool/main/p/pyfribidi",
        "first_seen": "20110127T084257Z",
        "size": 92793
      },
      {
        "name": "pyfribidi_0.6.0.orig.tar.gz",
        "archive_name": "debian-archive",
        "path": "/debian/pool/main/p/pyfribidi",
        "first_seen": "20120328T092752Z",
        "size": 92793
      }
    ],
...

Same with ldaptor 0.0.43-1.

SR

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_ZA.UTF-8, LC_CTYPE=en_ZA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)