Re: Bug#907806: How to disable tests for Python2 only?
Hi Yaroslav,
On Mon, Sep 24, 2018 at 09:40:49AM -0400, Yaroslav Halchenko wrote:
>
> On Mon, 24 Sep 2018, Andreas Tille wrote:
>
> > When you talked about new upstream version: Do you want to give 0.20rc1
>
> I did give it a try...
>
> From the now empty list of
> https://github.com/scikit-learn/scikit-learn/issues/created_by/yarikoptic it
> might be that all of the ones I've filed are addressed by now, BUT I do not see
> them in
>
> $> git lg 0.20rc1..origin/0.20.X
> * c196ec405 - (origin/0.20.X) Remove OPTICS from 0.20 (#12053) (7 days ago) [Joel Nothman]
> * 17f8016c5 - Bugfix release of joblib that also restores PyPy support (#12012) (3 weeks ago) [Olivier Grisel]
> * c40726e91 - CI handle sparse checkout with new branch (4 weeks ago) [Joel Nothman]
> * 96a3e21fb - CI Verbosity in push_doc (4 weeks ago) [Joel Nothman]
> * 9c3ecb2c4 - CI use correct scikit-learn.github.io branch (4 weeks ago) [Joel Nothman]
> * 061343e9f - CI Only try to remove docs dir if present (4 weeks ago) [Joel Nothman]
>
> so might have been fixed in master, and not backported yet, which indeed
> might be the case:
> https://github.com/scikit-learn/scikit-learn/issues/12016#issuecomment-419079493
You asked me to clone http://github.com/yarikoptic/scikit-learn to
https://salsa.debian.org/science-team/scikit-learn which I did. In
*your* packaging repository is no branch 0.20rc1 those commits would be
either needed to be imported as quilt patches or alternatively you can
use git mode in d/watch which creates a new tarball for you
incorporating the latest state of upstream Git (I doubt that would be a
sensible solution in the current case).
> > a try or do you want to wait for 0.20?
>
> regarding push to salsa:
>
> something is funky with salsa or with my network?
>
> (git)hopa:~deb/scikit-learn[debian-0.20]
> $> git remote add salsa git@salsa.debian.org:science-team/scikit-learn.git
>
> $> git fetch salsa
> ssh: connect to host salsa.debian.org port 22: Network is unreachable
> fatal: Could not read from remote repository.
>
> Please make sure you have the correct access rights
> and the repository exists.
I have no trouble with accessing the repository on Salsa.
> Meanwhile, debian-0.20 branch is on
> http://github.com/yarikoptic/scikit-learn
I admit I'm not sure what you want me to do next. It somehow smells
like using git mode in debian/watch and try to extract your commits to
debian/ dir via `git format-patch` and import these into Debian Science
repository via `git am`. However, I do not see this as very promising
since I'm not sure whether you are really in favour to migrate to Debian
Science or rather stick to your workflow. So before I start spending
time into this it would be helpful if you confirm that you can
gbp clone git@salsa.debian.org:science-team/scikit-learn.git
and we both agree about the method how we want to inject the upstream
source there. Debian Science policy says this is done via
gbp import-orig --pristine-tar <upstream_tarball>
while the upstream tarball is obtained via uscan or some get-orig-source
script in exceptional cases. What do you think about this?
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: