[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1005159: marked as done (xrdp: please also source ~/.profile in startwm.sh)

Your message dated Fri, 01 Apr 2022 11:03:55 +0000
with message-id <E1naF4N-000Am6-MW@fasolo.debian.org>
and subject line Bug#1005159: fixed in xrdp 0.9.19-1
has caused the Debian Bug report #1005159,
regarding xrdp: please also source ~/.profile in startwm.sh
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1005159: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005159
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xrdp
Version: 0.9.17-2
Severity: normal
Tags: patch

Hi,

/etc/xrdp/startwm.sh doesn't source $HOME/.profile, which results in
$HOME/.local/bin not being in $PATH when a terminal is opened (most
terminals execute non-login shells by default).

GDM does it in /etc/gdm3/Xsession, and I guess it's also implicitly done
by startx too (since a console login is a login shell, so ~/.profile
would be sourced, and $PATH would be inherited by terminals opened in
the X server started by startx; I didn't test this but this seems logical), so I think it's safe. 

I tried on my PC by directly modifying /etc/xrdp/startwm.sh and this
worked as intended, with no visible side-effects.

Thanks !

Regards,

--
Raphaël Halimi

From c8fdd8a7f3f151fd9269e59b57ba7280afcee360 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Halimi?= <raphael.halimi@gmail.com>
Date: Mon, 7 Feb 2022 20:35:10 +0100
Subject: [PATCH] startwm.sh: source ~/.profile too

---
 debian/startwm.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/debian/startwm.sh b/debian/startwm.sh
index 3127740a..a1d08c1a 100755
--- a/debian/startwm.sh
+++ b/debian/startwm.sh
@@ -10,5 +10,9 @@ if test -r /etc/profile; then
 	. /etc/profile
 fi
 
+if test -r $HOME/.profile; then
+	. $HOME/.profile
+fi
+
 test -x /etc/X11/Xsession && exec /etc/X11/Xsession
 exec /bin/sh /etc/X11/Xsession
-- 
2.34.1

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: xrdp
Source-Version: 0.9.19-1
Done: Dominik George <natureshadow@debian.org>

We believe that the bug you reported is fixed in the latest version of
xrdp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1005159@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dominik George <natureshadow@debian.org> (supplier of updated xrdp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 01 Apr 2022 12:08:42 +0200
Source: xrdp
Architecture: source
Version: 0.9.19-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Remote Maintainers <debian-remote@lists.debian.org>
Changed-By: Dominik George <natureshadow@debian.org>
Closes: 990806 1005159
Changes:
 xrdp (0.9.19-1) unstable; urgency=medium
 .
   * New upstream version.
   * Acknowledge NMUs - thanks to arnaudr and carnil!
   * Drop patch for CVE-2022-23613; included upstream.
   * Refresh patches.
   * Also source ~/.profile in startwm; thanks to Raphaël Halimi
     (Closes: #1005159)
   * Install logrotate configuration; thanks to Evan Linde (Closes: #990806)
   * Update d/copyright.
Checksums-Sha1:
 3ff67a809754048d46e254717ba0b364fadc9b80 1685 xrdp_0.9.19-1.dsc
 cd88ea49d63e4acdf45308e614b03137b3e038f3 2020366 xrdp_0.9.19.orig.tar.gz
 c93e39c9ae573004454b6212be5c9d6bafe8b373 22912 xrdp_0.9.19-1.debian.tar.xz
 24942e1add5a85bc50801b85ab0f96c0daff3156 7714 xrdp_0.9.19-1_amd64.buildinfo
Checksums-Sha256:
 bfaec798308c1f360f85ce16817584be6a936ec8dc35dd2d0eef2670be260994 1685 xrdp_0.9.19-1.dsc
 94017d30e475c6d7a24f651e16791551862ae46f82d8de62385e63393f5f93d0 2020366 xrdp_0.9.19.orig.tar.gz
 c49a38c8fa4cdf4c5abe6dbfda411fb7d95b0548fb3972a12b10a0b3cb3db9aa 22912 xrdp_0.9.19-1.debian.tar.xz
 b04de57c34d95d9c6421bdfdbac1af8a16c28b35e21aa85d0d67b19c6e0d5488 7714 xrdp_0.9.19-1_amd64.buildinfo
Files:
 dfbda32dbe19215523ca609559cf3118 1685 net optional xrdp_0.9.19-1.dsc
 2e60a2e874f95723a4cdd0b466bbe7e4 2020366 net optional xrdp_0.9.19.orig.tar.gz
 b70e42007f0fd4c1c66a5247968af9a5 22912 net optional xrdp_0.9.19-1.debian.tar.xz
 35845c19418a62951eec6df0d26bfbb1 7714 net optional xrdp_0.9.19-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iKcEARYKAE8WIQSk6zxRYJYchegBkTEK5VTlRg4b3QUCYkbYgTEaaHR0cHM6Ly93
d3cuZG9taW5pay1nZW9yZ2UuZGUvZ3BnLXBvbGljeS50eHQuYXNjAAoJEArlVOVG
DhvdTRQBAOOMVDo1HSf8ZAlAgSzRubQJoH/Z6edmmg+MaRwc0IsmAQDD5U4DIsnV
AKtvh7BheLUPjsKXlgHKWBQ9wXZtniy3CQ==
=DZiX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: