[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1043444: marked as done (bookworm-pu: package gosa-plugins-systems/2.8~git20211027.5741b8f-4+deb12u1)

Your message dated Sat, 07 Oct 2023 09:59:39 +0000
with message-id <E1qp45z-00A4CB-Hl@coccia.debian.org>
and subject line Released with 12.2
has caused the Debian Bug report #1043444,
regarding bookworm-pu: package gosa-plugins-systems/2.8~git20211027.5741b8f-4+deb12u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1043444: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043444
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: gosa-plugins-systems@packages.debian.org, debian-edu@lists.debian.org
Control: affects -1 + src:gosa-plugins-systems

As part of the effort of getting Debian Edu 12 ready for release (whilst
having all fixes/changes/features shipped in Debian 12) we have fixed an
issue with the systems plugin of GOsa².

[ Reason ]
In the current version, it is not possible to enable DHCP/DNS entries
for GOsa² system hosts when using GOsa²'s new UI theme.

[ Impact ]
DNS/DHCP settings in GOsa² will be usable/clickable if people use the new
default UI theme.

[ Tests ]
Manual tests in webbrowser.

[ Risks ]
Minimal, GOsa² users might experience regressions if something is still
broken or fixed inappropriately.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

+  * debian/patches:
+    + Add 1002_fix-dhcp-dns-checkboxes.patch fixing checkboxes. (Closes:
+      #1041619).

[ Other info ]
This p-u is part of the upcoming Debian Edu 12 release and is required to get
Debian Edu fully functional in Debian 12.

diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog	2023-05-16 23:10:07.000000000 +0200
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/changelog	2023-08-11 09:29:41.000000000 +0200
@@ -1,3 +1,12 @@
+gosa-plugins-systems (2.8~git20211027.5741b8f-4+deb12u1) bookworm; urgency=medium
+
+  [ Guido Berhoerster ]
+  * debian/patches:
+    + Add 1002_fix-dhcp-dns-checkboxes.patch fixing checkboxes. (Closes:
+      #1041619).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Fri, 11 Aug 2023 09:29:41 +0200
+
 gosa-plugins-systems (2.8~git20211027.5741b8f-4) unstable; urgency=medium
 
   * debian/control:
diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1002_fix-dhcp-dns-checkboxes.patch gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1002_fix-dhcp-dns-checkboxes.patch
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1002_fix-dhcp-dns-checkboxes.patch	1970-01-01 01:00:00.000000000 +0100
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/1002_fix-dhcp-dns-checkboxes.patch	2023-08-11 09:18:05.000000000 +0200
@@ -0,0 +1,44 @@
+From: Guido Berhoerster <guido@berhoerster.name>
+Subject: Fix DHCP and DNS checkboxes when adding systems
+
+This changes the checkboxes on the network template of the default theme so
+that they conform to the markup structure expected by materialize.css.
+--- gosa-plugins-systems.orig/admin/systems/default/network.tpl
++++ gosa-plugins-systems/admin/systems/default/network.tpl
+@@ -39,13 +39,13 @@
+ 
+   {if $dhcpEnabled}
+     {if $dhcpParentNodeCnt}
++        <label>
+       {render acl=$dhcpSetupACL}
+-        <div class="input-field">
+           <input type="checkbox" name="dhcp_is_Account" onClick="document.mainform.submit();" {if $dhcp_is_Account} checked {/if}>
+-        </div>
+       {/render}
+ 
+-      <p>{t}Enable DHCP for this device{/t}</p>
++          <span>{t}Enable DHCP for this device{/t}</span>
++        </label>
+ 
+       {render acl=$dhcpSetupACL}
+         {image path="<i class='material-icons input-icons'>refresh</i>"}
+@@ -85,17 +85,17 @@
+           {else}
+             <label>
+               <input type="checkbox" name="DNS_is_account" value="1" checked="checked" onclick="$('test2').toggle(); $('propose_ip').toggle();" />
++              <span>{t}Enable DNS for this device{/t}</span>
+             </label>
+           {/if}
+         {else}
+             <label>
+               <input type="checkbox" name="DNS_is_account" value="1" onclick="$('test2').toggle();$('propose_ip').toggle();" />
++              <span>{t}Enable DNS for this device{/t}</span>
+             </label>
+         {/if}
+       {/render}
+ 
+-      <p>{t}Enable DNS for this device{/t}</p>
+-
+       {render acl=$dnsSetupACL}
+         <div class="input-field">
+           <select name="zoneName" id="zoneName" size=1>
diff -Nru gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series
--- gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series	2023-03-17 11:41:14.000000000 +0100
+++ gosa-plugins-systems-2.8~git20211027.5741b8f/debian/patches/series	2023-08-11 09:18:05.000000000 +0200
@@ -3,3 +3,4 @@
 0003_add-dhcp-schema.patch
 0004_integrate-goto-plugin-code.patch
 1001_php8.2-deprecations.patch
+1002_fix-dhcp-dns-checkboxes.patch

--- End Message ---
--- Begin Message --- 
Version: 12.2

The upload requested in this bug has been released as part of 12.2.

--- End Message ---
Reply to: