[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035039: unblock: node-core-js/3.26.1-3



On 2023-05-04 06:52:56 +0400, Yadd wrote:
> Hi,
> 
> here is a new debdiff:
> 
> Please unblock package node-core-js

Updated my hint.

Cheers

> 
> [ Reason ]
> 1. "Breaks" field isn't enough for apt, it needs a "Replaces" to manage
>    file conflicts (#1034947, #1034980, #1034989, #1035000)
> 2. During build, there was a useless symlink (#1035439)
> 
> [ Risks ]
> No risk here
> 
> [ Checklist ]
>   [X] all changes are documented in the d/changelog
>   [X] I reviewed all changes and I approve them
>   [X] attach debdiff against the package in testing
> 
> Cheers,
> Yadd
> 
> unblock node-core-js/3.26.1-3

> diff --git a/debian/changelog b/debian/changelog
> index f85b17e..953664b 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,18 @@
> +node-core-js (3.26.1-3) unstable; urgency=medium
> +
> +  * Team upload
> +  * Drop dandling link (Closes: #1035439)
> +
> + -- Yadd <yadd@debian.org>  Wed, 03 May 2023 17:55:43 +0400
> +
> +node-core-js (3.26.1-2) unstable; urgency=medium
> +
> +  * Team upload
> +  * Duplicate Breaks fields with Replaces
> +    (Closes: #1034980, #1034989, 1035000, #1034947)
> +
> + -- Yadd <yadd@debian.org>  Fri, 28 Apr 2023 06:52:43 +0400
> +
>  node-core-js (3.26.1-1) unstable; urgency=medium
>  
>    * Team upload
> diff --git a/debian/control b/debian/control
> index cce0fb8..955a902 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -41,6 +41,7 @@ Depends: ${misc:Depends}
>   , node-semver
>   , webpack
>  Breaks: node-core-js (<< 3.21.1~)
> +Replaces: node-core-js (<< 3.21.1~)
>  Description: Node.js module to build a custom core-js
>   For some cases could be useful to exclude some `core-js` features or
>   generate a polyfill for target engines. This API helps conditionally include
> @@ -52,6 +53,7 @@ Architecture: all
>  Depends: ${misc:Depends}
>  Multi-Arch: foreign
>  Breaks: node-core-js (<< 3.21.1~)
> +Replaces: node-core-js (<< 3.21.1~)
>  Description: Modular version of core-js to load only required features
>   core-js is a modular standard library for JavaScript. Includes polyfills for
>   ECMAScript up to 2021: promises, symbols, collections, iterators, typed
> @@ -65,6 +67,7 @@ Depends: ${misc:Depends}
>   , node-semver
>  Multi-Arch: foreign
>  Breaks: node-core-js (<< 3.21.1~)
> +Replaces: node-core-js (<< 3.21.1~)
>  Description: data about the necessity of core-js
>   core-js-compat contains data about the necessity of core-js modules and API
>   for getting a list of required core-js modules by browserslist query.
> @@ -74,6 +77,7 @@ Architecture: all
>  Depends: ${misc:Depends}
>  Multi-Arch: foreign
>  Breaks: node-core-js (<< 3.21.1~)
> +Replaces: node-core-js (<< 3.21.1~)
>  Description: Modular standard library for JavaScript without global namespace pollution
>   Includes polyfills for ECMAScript up to 2021: promises, symbols,
>   collections, iterators, typed arrays, ECMAScript 7+ proposals, setImmediate,
> diff --git a/debian/rules b/debian/rules
> index 7273a22..8760023 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -8,7 +8,7 @@ override_dh_auto_build:
>  	zx scripts/build-indexes.mjs
>  	zx scripts/clean-and-copy.mjs
>  	zx scripts/build-compat/index.mjs
> -	ln -s ../packages/core-js node_modules/core-js || true
> +	[ -e node_modules/core-js ] || ln -s ../packages/core-js node_modules/ || true
>  	zx scripts/bundle-package/bundle-package.mjs
>  	rm -f node_modules/core-js core-js
>  	terser -o packages/core-js-bundle/index.min.js packages/core-js-bundle/index.js


-- 
Sebastian Ramacher


Reply to: