On Tue, Sep 07, 2021 at 08:38:58PM +0300, Boian Bonev wrote: > Or maybe I misunderstand now - in case you mean that some of the fixes > are not acceptable, please clarify which patches to drop and which to > keep. In my opinion all the 3 fixes are trivial, have been tested, have > low risk, will improve user experience and are safe to keep, but I may > be missing something. > > Here is the changelog, hope that helps to make things unambiguous: > I mean you have requested an update fixing the crash on unicode process names, but you also included other fixes and enhancements: > * Backport bugfixes from 1.18 > - fix OOB access caused by UTF8 process names This is fine. > - fix screen flicker during refresh with visible help This is fine if it is serious enough to be causing real problems (not just cosmetic). > - allow ESC to close the help window This is behaviour change or enhancement, it is generally not OK in a stable update unless you can convince us it has a really good case e.g. the only way to fix a security issue. While you are doing that please also ensure the changelog refers to appropriate bugs in the BTS so that the changes are easily traced back. Thanks, -- Jonathan Wiltshire jmw@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
Attachment:
signature.asc
Description: PGP signature