Your message dated Sat, 06 Feb 2021 10:39:26 +0000 with message-id <6425525e38201ecf9a2d3e0f1e63c0d3b08e0fc0.camel@adam-barratt.org.uk> and subject line Closing p-u bugs for updates in 10.8 has caused the Debian Bug report #977172, regarding buster-pu: package qxmpp/1.0.0-4+deb10u1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 977172: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977172 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: buster-pu: package qxmpp/1.0.0-4+deb10u1
- From: Boris Pek <tehnick-8@yandex.ru>
- Date: Sat, 12 Dec 2020 05:04:00 +0300
- Message-id: <3570101607738529@mail.yandex.ru>
Package: release.debian.org Severity: normal Tags: buster User: release.debian.org@packages.debian.org Usertags: pu Dear release team, I would like to push a fix for potential SEGFAULT on connection error in qxmpp library. Proposed patch is well tested in Debian unstable since qxmpp/1.0.0-5. Debdiff is attached. Please consider accepting this as a buster-pu. Thanks, Borisdiff -Nru qxmpp-1.0.0/debian/changelog qxmpp-1.0.0/debian/changelog --- qxmpp-1.0.0/debian/changelog 2019-01-19 21:56:20.000000000 +0300 +++ qxmpp-1.0.0/debian/changelog 2020-12-12 04:33:07.000000000 +0300 @@ -1,3 +1,10 @@ +qxmpp (1.0.0-4+deb10u1) buster; urgency=medium + + * Add patch fix-segfault-on-connection-error: + fixes potential SEGFAULT on connection error. + + -- Boris Pek <tehnick@debian.org> Sat, 12 Dec 2020 04:33:07 +0300 + qxmpp (1.0.0-4) unstable; urgency=medium * Update debian/control: diff -Nru qxmpp-1.0.0/debian/patches/fix-segfault-on-connection-error.patch qxmpp-1.0.0/debian/patches/fix-segfault-on-connection-error.patch --- qxmpp-1.0.0/debian/patches/fix-segfault-on-connection-error.patch 1970-01-01 03:00:00.000000000 +0300 +++ qxmpp-1.0.0/debian/patches/fix-segfault-on-connection-error.patch 2020-12-12 04:15:35.000000000 +0300 @@ -0,0 +1,31 @@ +Description: Fix potential SEGFAULT on connection error + `socketError()` calls `connectToNextDNSHost()` which might cause + `socketError()` synchronously (and recursively), thus not giving a + change for updating `nextSrvRecordIdx`. + . + Overall, this results in attempting to connect to the same DNS record + recursively, until the stack is exhausted, resulting in SEGFAULT. + . + One of the solutions (done in this commit) is to increment the record + index _before_ attempting to connect. +Origin: upstream, https://github.com/qxmpp-project/qxmpp/commit/daa03c8e +Last-Update: 2019-10-12 + + +--- a/src/client/QXmppOutgoingClient.cpp ++++ b/src/client/QXmppOutgoingClient.cpp +@@ -165,11 +165,10 @@ + + void QXmppOutgoingClientPrivate::connectToNextDNSHost() + { ++ auto curIdx = nextSrvRecordIdx++; + connectToHost( +- dns.serviceRecords().at(nextSrvRecordIdx).target(), +- dns.serviceRecords().at(nextSrvRecordIdx).port()); +- +- nextSrvRecordIdx++; ++ dns.serviceRecords().at(curIdx).target(), ++ dns.serviceRecords().at(curIdx).port()); + } + + /// Constructs an outgoing client stream. diff -Nru qxmpp-1.0.0/debian/patches/series qxmpp-1.0.0/debian/patches/series --- qxmpp-1.0.0/debian/patches/series 2019-01-19 21:56:19.000000000 +0300 +++ qxmpp-1.0.0/debian/patches/series 2020-12-12 04:15:35.000000000 +0300 @@ -1 +1,2 @@ bump-SONAME.patch +fix-segfault-on-connection-error.patch
--- End Message ---
--- Begin Message ---
- To: 955277-done@bugs.debian.org, 962152-done@bugs.debian.org, 962672-done@bugs.debian.org, 970745-done@bugs.debian.org, 972149-done@bugs.debian.org, 973342-done@bugs.debian.org, 973706-done@bugs.debian.org, 975932-done@bugs.debian.org, 976094-done@bugs.debian.org, 976392-done@bugs.debian.org, 976423-done@bugs.debian.org, 976432-done@bugs.debian.org, 977172-done@bugs.debian.org, 977511-done@bugs.debian.org, 977520-done@bugs.debian.org, 977735-done@bugs.debian.org, 977782-done@bugs.debian.org, 977895-done@bugs.debian.org, 977978-done@bugs.debian.org, 978091-done@bugs.debian.org, 978157-done@bugs.debian.org, 979072-done@bugs.debian.org, 979074-done@bugs.debian.org, 979724-done@bugs.debian.org, 979749-done@bugs.debian.org, 980133-done@bugs.debian.org, 980201-done@bugs.debian.org, 980259-done@bugs.debian.org, 980268-done@bugs.debian.org, 980453-done@bugs.debian.org, 980458-done@bugs.debian.org, 980491-done@bugs.debian.org, 980762-done@bugs.debian.org, 980799-done@bugs.debian.org, 980802-done@bugs.debian.org, 980835-done@bugs.debian.org, 980857-done@bugs.debian.org, 980919-done@bugs.debian.org, 980938-done@bugs.debian.org, 980962-done@bugs.debian.org, 981002-done@bugs.debian.org, 981035-done@bugs.debian.org, 981047-done@bugs.debian.org, 981059-done@bugs.debian.org, 981096-done@bugs.debian.org, 981239-done@bugs.debian.org, 981271-done@bugs.debian.org, 981292-done@bugs.debian.org, 981339-done@bugs.debian.org, 981345-done@bugs.debian.org
- Subject: Closing p-u bugs for updates in 10.8
- From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
- Date: Sat, 06 Feb 2021 10:39:26 +0000
- Message-id: <6425525e38201ecf9a2d3e0f1e63c0d3b08e0fc0.camel@adam-barratt.org.uk>
Package: release.debian.org Version: 10.8 Hi, Each of the updates referenced by these bugs was included in today's 10.8 point release. Regards, Adam
--- End Message ---