[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#942104: marked as done (britney: fails if Release file missing "Suite" field)

Your message dated Wed, 23 Oct 2019 19:34:00 +0000
with message-id <89d8512b-b9d0-175e-c18e-fbe55a6e4ed6@thykier.net>
and subject line Re: Bug#942104: release.debian.org: Will fail if "Suite" field is missing
has caused the Debian Bug report #942104,
regarding britney: fails if Release file missing "Suite" field
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
942104: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942104
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: britney

britney assumes that if you have a Release file, it will contain a "Suite"
field. That's not true, the "Codename" entry is required but the "Suite"
one is optional.

Please handle properly that case:
[...]
I: [2019-10-10T12:39:21+0000] - Loading source packages from /srv/repo.kali.org/ftp/kali/dists/kali-dev/non-free/source/Sources.gz
Traceback (most recent call last):
  File "./britney.py", line 1529, in <module>
    Britney().main()
  File "./britney.py", line 284, in __init__
    self.__parse_arguments()
  File "./britney.py", line 463, in __parse_arguments
    self.suite_info = suite_loader.load_suites()
  File "/srv/repo.kali.org/tools/britney2/britney2/inputs/suiteloader.py", line 116, in load_suites
    self._update_suite_name(suite)
  File "/srv/repo.kali.org/tools/britney2/britney2/inputs/suiteloader.py", line 146, in _update_suite_name
    suite.name = release_file['Suite']
KeyError: 'Suite'

Cheers,

-- System Information:
Debian Release: bullseye/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- End Message ---
--- Begin Message --- 
Raphael Hertzog:
> Control: tag -1 + patch
> 
> On Thu, 10 Oct 2019, Ansgar wrote:
>> https://wiki.debian.org/DebianRepository/Format#A.22Release.22_files
>> says one of Suite and Codename is required.  Codename itself is not required.
> 
> Ok.
> 
>> I wouldn't be surprised if many tools just use one and assume it always
>> exists and would recommend to always provide both.
> 
> Well, that's not really an option for me right now. Because APT will just
> complain if you add a "Suite" when it was missing before hand.
> 
> In any case, here's a suggested patch (attached).
> 
> Cheers,
> 

Thanks for filing the bug.

I have fixed this now with a slightly different approach (the main
difference being that "Codename" is not required as was the case in the
proposed patch).

Commit in master being: a6e358119533289447a8462a2bd230c99f8ddc87

Thanks,
~Niels

--- End Message ---
Reply to: