[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924240: marked as done (unblock: getmail/5.13-1)



Your message dated Sun, 10 Mar 2019 14:41:56 +0000
with message-id <20190310144156.GA23415@powdarrmonkey.net>
and subject line Re: Bug#924240: unblock: getmail/5.13-1
has caused the Debian Bug report #924240,
regarding unblock: getmail/5.13-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
924240: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924240
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package getmail

(explain the reason for the unblock here)
Since old python gnome binding doesn't work any more and packages are
removed, Suggests is updated,

Also, upstream has addressed SNI support issues with more fine grained
python version in mind, let's update it to support gmail users and
for easier future security updates for backports.

(include/attach the debdiff against the package in testing)
$ debdiff getmail_5.11-1.dsc getmail_5.13-1.dsc
diff -Nru getmail-5.11/debian/changelog getmail-5.13/debian/changelog
--- getmail-5.11/debian/changelog	2019-02-15 07:31:35.000000000 +0900
+++ getmail-5.13/debian/changelog	2019-02-24 22:49:27.000000000 +0900
@@ -1,3 +1,18 @@
+getmail (5.13-1) unstable; urgency=medium
+
+  * New upstream version (Fix SNI change with Python < 2.7 for
+    backport compatibility)
+
+ -- Osamu Aoki <osamu@debian.org>  Sun, 24 Feb 2019 22:49:27 +0900
+
+getmail (5.11-2) unstable; urgency=medium
+
+  * Drop --store-password-in-gnome-keyring support since
+    python-gnomekeyring is not available any more on Debian.
+    Closes: #912963
+
+ -- Osamu Aoki <osamu@debian.org>  Wed, 20 Feb 2019 23:53:40 +0900
+
 getmail (5.11-1) unstable; urgency=medium
 
   * New upstream version
@@ -10,7 +25,7 @@
   * New upstream version (docs update)
   * Standards-Version: bump to 4.3.0 (no changes needed)
 
- -- Daniel Kahn Gillmor <dkg@fifthhorseman.net>  Thu, 14 Feb 2019 17:31:27 -0500
+ -- Daniel Kahn Gillmor <dkg@fifthhorseman.net>  Fri, 08 Feb 2019 10:24:57 -0500
 
 getmail (5.8-1) unstable; urgency=medium
 
diff -Nru getmail-5.11/debian/control getmail-5.13/debian/control
--- getmail-5.11/debian/control	2019-02-09 00:25:13.000000000 +0900
+++ getmail-5.13/debian/control	2019-02-24 22:45:06.000000000 +0900
@@ -21,9 +21,6 @@
 Depends:
  ${misc:Depends},
  ${python:Depends},
-Suggests:
- python-gnomekeyring,
- python-gobject,
 Provides:
  getmail4,
 Breaks:
diff -Nru getmail-5.11/docs/CHANGELOG getmail-5.13/docs/CHANGELOG
--- getmail-5.11/docs/CHANGELOG	2019-02-13 23:40:50.000000000 +0900
+++ getmail-5.13/docs/CHANGELOG	2019-02-23 12:18:36.000000000 +0900
@@ -1,3 +1,12 @@
+Version 5.13
+22 February 2019
+    -second attempt at fixing SNI change with Python < 2.7.  Thanks: "Cimbal".
+
+Version 5.12
+22 February 2019
+    -bugfix: the SNI change broke something else with Python 2.6 and earlier;
+    fixed.  Thanks: "Cimbal".
+
 Version 5.11
 13 February 2019
     -bugfix: the SNI change did not work correctly with Python < 2.7.13;
diff -Nru getmail-5.11/getmailcore/__init__.py getmail-5.13/getmailcore/__init__.py
--- getmail-5.11/getmailcore/__init__.py	2019-02-13 23:40:50.000000000 +0900
+++ getmail-5.13/getmailcore/__init__.py	2019-02-23 12:15:57.000000000 +0900
@@ -16,7 +16,7 @@
     raise ImportError('getmail version 4 requires Python version 2.3.3'
                       ' or later')
 
-__version__ = '5.11'
+__version__ = '5.13'
 
 __all__ = [
     'baseclasses',
diff -Nru getmail-5.11/getmailcore/_retrieverbases.py getmail-5.13/getmailcore/_retrieverbases.py
--- getmail-5.11/getmailcore/_retrieverbases.py	2019-02-13 23:40:50.000000000 +0900
+++ getmail-5.13/getmailcore/_retrieverbases.py	2019-02-23 12:15:57.000000000 +0900
@@ -70,6 +70,7 @@
     proto_best = getattr(ssl, 'PROTOCOL_TLS', None)
     if not proto_best:
         proto_best = getattr(ssl, 'PROTOCOL_SSLv23', None)
+    has_ciphers = sys.hexversion >= 0x2070000
 
     # Monkey-patch SNI use into SSL.wrap_socket() if supported
     if has_sni:
@@ -79,12 +80,15 @@
                          do_handshake_on_connect=True,
                          suppress_ragged_eofs=True,
                          ciphers=None, server_hostname=None):
-            return ssl.SSLSocket(sock=sock, keyfile=keyfile, certfile=certfile,
-                                 server_side=server_side, cert_reqs=cert_reqs,
-                                 ssl_version=ssl_version, ca_certs=ca_certs,
-                                 do_handshake_on_connect=do_handshake_on_connect,
-                                 suppress_ragged_eofs=suppress_ragged_eofs,
-                                 ciphers=ciphers, server_hostname=server_hostname)
+            kwargs = dict(sock=sock, keyfile=keyfile, certfile=certfile,
+                          server_side=server_side, cert_reqs=cert_reqs,
+                          ssl_version=ssl_version, ca_certs=ca_certs,
+                          do_handshake_on_connect=do_handshake_on_connect,
+                          suppress_ragged_eofs=suppress_ragged_eofs,
+                          ciphers=ciphers, server_hostname=server_hostname)
+            if not has_ciphers:
+                kwargs.pop('ciphers', None)
+            return ssl.SSLSocket(**kwargs)
     else:
         # no SNI support
         def _wrap_socket(sock, keyfile=None, certfile=None,
@@ -93,12 +97,15 @@
                          do_handshake_on_connect=True,
                          suppress_ragged_eofs=True,
                          ciphers=None, server_hostname=None):
-            return ssl.SSLSocket(sock=sock, keyfile=keyfile, certfile=certfile,
-                                 server_side=server_side, cert_reqs=cert_reqs,
-                                 ssl_version=ssl_version, ca_certs=ca_certs,
-                                 do_handshake_on_connect=do_handshake_on_connect,
-                                 suppress_ragged_eofs=suppress_ragged_eofs,
-                                 ciphers=ciphers)
+            kwargs = dict(sock=sock, keyfile=keyfile, certfile=certfile,
+                          server_side=server_side, cert_reqs=cert_reqs,
+                          ssl_version=ssl_version, ca_certs=ca_certs,
+                          do_handshake_on_connect=do_handshake_on_connect,
+                          suppress_ragged_eofs=suppress_ragged_eofs,
+                          ciphers=ciphers)
+            if not has_ciphers:
+                kwargs.pop('ciphers', None)
+            return ssl.SSLSocket(**kwargs)
     ssl.wrap_socket = _wrap_socket
 
     # Is it recent enough to have hostname matching (Python 3.2+)?
diff -Nru getmail-5.11/getmail.spec getmail-5.13/getmail.spec
--- getmail-5.11/getmail.spec	2019-02-13 23:40:54.000000000 +0900
+++ getmail-5.13/getmail.spec	2019-02-23 12:18:42.000000000 +0900
@@ -2,7 +2,7 @@
 
 Summary: POP3 mail retriever with reliable Maildir delivery
 Name: getmail
-Version: 5.11
+Version: 5.13
 Release: 1
 License: GPL
 Group: Applications/Internet
@@ -52,6 +52,15 @@
 %{python_sitelib}/getmailcore/
 
 %changelog
+* Fri Feb 22 2019 Charles Cazabon <charlesc-getmail-rpm@pyropus.ca>
+-update to version 5.13
+
+* Fri Feb 22 2019 Charles Cazabon <charlesc-getmail-rpm@pyropus.ca>
+-update to version 5.13
+
+* Fri Feb 22 2019 Charles Cazabon <charlesc-getmail-rpm@pyropus.ca>
+-update to version 5.12
+
 * Wed Feb 13 2019 Charles Cazabon <charlesc-getmail-rpm@pyropus.ca>
 -update to version 5.11
 
diff -Nru getmail-5.11/PKG-INFO getmail-5.13/PKG-INFO
--- getmail-5.11/PKG-INFO	2019-02-13 23:40:55.000000000 +0900
+++ getmail-5.13/PKG-INFO	2019-02-23 12:18:43.000000000 +0900
@@ -1,6 +1,6 @@
 Metadata-Version: 1.1
 Name: getmail
-Version: 5.11
+Version: 5.13
 Summary: a mail retrieval, sorting, and delivering system
 Home-page: http://pyropus.ca/software/getmail/
 Author: Charles Cazabon


unblock getmail/5.13-1

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- End Message ---
--- Begin Message ---
On Sun, Mar 10, 2019 at 11:40:49PM +0900, Osamu Aoki wrote:
> Please unblock package getmail

An unblock is not required, the package is expected to migrate on its own
before we begin full freeze.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

--- End Message ---

Reply to: