[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704159: marked as done (unblock (pre-approval) : clang/1:3.0-6.2)

Your message dated Mon, 01 Apr 2013 18:54:57 +0100
with message-id <1364838897.6905.31.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#704159: unblock (pre-approval) : clang/1:3.0-6.2
has caused the Debian Bug report #704159,
regarding unblock (pre-approval) : clang/1:3.0-6.2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
704159: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704159
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please approve my upload for package clang, this fixes two issues one of which
is filed as a grave bug. The other I also judge to be grave but is not currently
filed as a bug in debian (if you want me to file it as one I will)

The first issue is on armhf. While I fixed the linker invocation some time ago
(and it took ages to get the patch uploaded due to arguments over the broken
3.1 version in sid which was eventually cleared as an epoch upload) I did not
think to test passing of floating point arguments between clang build code and
gcc built code.

It turns out that the CPU default clang was using on armhf was rediculously 
low and this causes clang to silently fail to correctly implement the hard 
float ABI. My patch raises the CPU default.

I have set the CPU default to armv6 because as far as I can tell clang 3.0's
armv7 setting's imply features that debian armhf doesn't have. Ubuntu has
a patch that solves this but I judged that patch too intrusive and hacky for
debian. So setting the default to armv6 appeared to be the "least bad" 
soloution.

The second change is for powerpc and was picked from ubuntu it stops the
package being built with altivec as the default since debian powerpc does
not require altivec. This patch was pointed out to me by adam conrad while
discussing the armhf issues.

Debdiff is attatched.

-- System Information:
Debian Release: 6.0.3
  APT prefers proposed-updates
  APT policy: (500, 'proposed-updates'), (500, 'oldstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

--- End Message ---
--- Begin Message --- 
On Sun, 2013-03-31 at 23:35 +0100, peter green wrote:
> Jonathan Wiltshire wrote:
> > I'd rather not have the DEP-3 boilerplate in your first patch; with that
> > removed, please go ahead with an upload to unstable and ping this bug when
> > it is ready.
> >   
> Done.

Looks like this got unblocked.

Regards,

Adam

--- End Message ---
Reply to: