Bug#799619: kio: FTBFS on hurd-i386: warning about posix_fadvise
Hello,
Unless somebody complains, I plan to NMU these changes, which are
completely harmless on non-Hurd, around 8th May.
Samuel
Samuel Thibault, on Sun 24 Apr 2016 13:00:44 +0200, wrote:
> Index: kio-5.16.0/src/ioslaves/file/file.cpp
> ===================================================================
> --- kio-5.16.0.orig/src/ioslaves/file/file.cpp
> +++ kio-5.16.0/src/ioslaves/file/file.cpp
> @@ -333,7 +333,7 @@ void FileProtocol::get(const QUrl &url)
> return;
> }
>
> -#if HAVE_FADVISE
> +#if HAVE_FADVISE && !defined(__GNU__)
> //TODO check return code
> posix_fadvise(f.handle(), 0, 0, POSIX_FADV_SEQUENTIAL);
> #endif
> Index: kio-5.16.0/src/ioslaves/file/file_unix.cpp
> ===================================================================
> --- kio-5.16.0.orig/src/ioslaves/file/file_unix.cpp
> +++ kio-5.16.0/src/ioslaves/file/file_unix.cpp
> @@ -128,7 +128,7 @@ void FileProtocol::copy(const QUrl &srcU
> return;
> }
>
> -#if HAVE_FADVISE
> +#if HAVE_FADVISE && !defined(__GNU__)
> posix_fadvise(src_file.handle(), 0, 0, POSIX_FADV_SEQUENTIAL);
> #endif
>
> @@ -144,7 +144,7 @@ void FileProtocol::copy(const QUrl &srcU
> return;
> }
>
> -#if HAVE_FADVISE
> +#if HAVE_FADVISE && !defined(__GNU__)
> posix_fadvise(dest_file.handle(), 0, 0, POSIX_FADV_SEQUENTIAL);
> #endif
>
> --- debian/libkf5kiocore5.symbols.original 2016-04-24 10:55:11.000000000 +0000
> +++ debian/libkf5kiocore5.symbols 2016-04-24 10:55:15.000000000 +0000
> @@ -901,12 +901,12 @@
> _ZN3KIO8UDSEntry6insertEjRK7QString@Base 4.96.0
> _ZN3KIO8UDSEntry6insertEjx@Base 4.96.0
> _ZN3KIO8UDSEntry7reserveEi@Base 5.5.0+git20141229.0049+15.04
> - (arch=kfreebsd-any)_ZN3KIO8UDSEntryC1ERK4statRK7QString@Base 5.11.0
> - (arch=!kfreebsd-any)_ZN3KIO8UDSEntryC1ERK6stat64RK7QString@Base 4.100.0
> + (arch=kfreebsd-any hurd-i386)_ZN3KIO8UDSEntryC1ERK4statRK7QString@Base 5.11.0
> + (arch=!kfreebsd-any !hurd-i386)_ZN3KIO8UDSEntryC1ERK6stat64RK7QString@Base 4.100.0
> _ZN3KIO8UDSEntryC1ERKS0_@Base 4.96.0
> _ZN3KIO8UDSEntryC1Ev@Base 4.96.0
> - (arch=kfreebsd-any)_ZN3KIO8UDSEntryC2ERK4statRK7QString@Base 5.11.0
> - (arch=!kfreebsd-any)_ZN3KIO8UDSEntryC2ERK6stat64RK7QString@Base 4.100.0
> + (arch=kfreebsd-any hurd-i386)_ZN3KIO8UDSEntryC2ERK4statRK7QString@Base 5.11.0
> + (arch=!kfreebsd-any !hurd-i386)_ZN3KIO8UDSEntryC2ERK6stat64RK7QString@Base 4.100.0
> _ZN3KIO8UDSEntryC2ERKS0_@Base 4.96.0
> _ZN3KIO8UDSEntryC2Ev@Base 4.96.0
> _ZN3KIO8UDSEntryD1Ev@Base 4.96.0
Reply to: