[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#735488: Qt4 in arm64: wrap up of the current situation



Thanks for the quick reply. [Adding back the needed CCs addresses.]

> W dniu 28.02.2014 15:19, Dmitry Shachnev pisze:
>> I had a quick look at patches you attached. Thanks a lot for submitting them in
>> such structured form. My questions are:
>> 
>> - Are 1-basic-aarch64-detection.patch, 2-mkspecs.patch and 4-syscalls.patch
>>   authored by you?
>
> Author: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl> based on
> gtkwebkit changes by Riku Voipio <riku.voipio@linaro.org>

Sorry for nitpicking, but these patches are not related to WebKit and
only touch files in QtCore. So I assume you are the only author.

>> - Did you forget to attach 3-something patch? Or is that just a naming issue?
>
> It got dropped.

OK.

>> - 5-qatomic patch has this line on top:
>>
>>     include/QtCore/headers.pri usuniФ™te - trzeba przywrУГciФ‡
>> 
>>   Can I ignore that?
>
> It means "include/QtCore/headers.pri changes are dropped - need to be
> restored". This is to get qatomics_aarch64.h file included in qt-devel.

So I am ignoring it, thanks.

>> The qtscript.patch is already committed to qtscript git [1], so we should probably
>> submit a cherry-pick upstream (anyone could do that) and make it included in the
>> next snapshot. For some reason Qt Gerrit refuses to accept my changes, so I would
>> welcome if someone else does that.
>
> And all included patches are BSD licensed.

I know, thanks.

--
Dmitry Shachnev

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: