Bug#1054266: libo3dgc-dev: typos in the headers

[IOhannes m zmoelnig <umlaeute@debian.org>]

Package: libo3dgc-dev
Severity: normal

Dear Maintainer,

while packaging assimp, I'm trying to use libo3dgc as a replacement for the
vendored open3dgc library.

however, it seems that the headers of this library are full of typos, which
makes me wonder whether they are actually used anywhere.

compiling gives me the following warnings:

> /usr/include/o3dgc/o3dgcSC3DMCDecoder.h:66:97: warning: no return statement in function returning non-void [-Wreturn-type]
>   66 |         O3DGCErrorCode              SetIterator(unsigned long iterator) { m_iterator = iterator;}

which is clearly an problem.

then there's also this "nice" typo:

> error: ‘class o3dgc::SC3DMCDecoder<short unsigned int>’ has no member named ‘DecodePayload’; did you mean ‘DecodePlayload’?
>   934 |     if (decoder.DecodePayload(ifs, bstream) != o3dgc::O3DGC_OK) {
>       |                 ^~~~~~~~~~~~~
>       |                 DecodePlayload

So the library uses 'DecodePlayload' but 'EncodePayload' :facepalm:


for assimp, i'm going to switch back to the vendored library.
but in general, i think libo3dgc has sub-par code quality.

cheers.