[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010785: marked as done (gdome2: reproducible-builds: embedded build paths libgdome.so.*)

Your message dated Wed, 22 Jun 2022 09:03:55 +0000
with message-id <E1o3wHD-00055I-4g@fasolo.debian.org>
and subject line Bug#1010785: fixed in gdome2 0.8.1+debian-9
has caused the Debian Bug report #1010785,
regarding gdome2: reproducible-builds: embedded build paths libgdome.so.*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1010785: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010785
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: gdome2
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/lib/libgdome.so.0.8.1:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/gdome2.html

  /build/1st/gdome2-0.8.1+debian/libgdome/gdome.c:65
  vs.
  /build/2/gdome2-0.8.1+debian/2nd/libgdome/gdome.c:65


The attached patch to debian/rules fixes this by passing
-ffile-prefix-map in CFLAGS and ensuring CFLAGS is passed to configure.

Alternately, updating the packaging to use dh/debhelper at a recent
compat level would also likely fix this.


With this patch applied, gdome2 should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From 65c23dfcbf5fd3a59d4a3141430247225e4d4413 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 9 May 2022 23:06:56 +0000
Subject: [PATCH] debian/rules: add -ffile-prefix-map to CFLAGS and ensure
 CFLAGS are passed in the configure phase.

---
 debian/rules | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 5e25754..ae361d7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,13 +11,15 @@ ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
 INSTALL_PROGRAM += -s
 endif
 
+CFLAGS += -ffile-prefix-map=$(CURDIR)=.
+
 configure: configure-stamp
 configure-stamp:
 	dh_testdir
 	cp /usr/share/misc/config.sub /usr/share/misc/config.guess .
 	libtoolize -c -f
 	autoreconf -f -i
-	./configure --prefix=/usr \
+	CFLAGS="$(CFLAGS)" ./configure --prefix=/usr \
 		    --mandir=\$${prefix}/share/man \
 		    --infodir=\$${prefix}/share/info \
 		    --with-html-dir=\$${prefix}/share/doc/libgdome2-dev 
-- 
2.36.0

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: gdome2
Source-Version: 0.8.1+debian-9
Done: Hugh McMaster <hugh.mcmaster@outlook.com>

We believe that the bug you reported is fixed in the latest version of
gdome2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010785@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hugh McMaster <hugh.mcmaster@outlook.com> (supplier of updated gdome2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 22 Jun 2022 09:58:41 +1000
Source: gdome2
Architecture: source
Version: 0.8.1+debian-9
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Hugh McMaster <hugh.mcmaster@outlook.com>
Closes: 1010785
Changes:
 gdome2 (0.8.1+debian-9) unstable; urgency=medium
 .
   * QA upload.
   * debian/rules: Remove manual CFLAGS handling and let debhelper pass valid
     optimization flags to enable reproducible builds (Closes: #1010785).
   * debian/patches: Output the GDOME_TEXT_NODE string to stdout. This fixes a
     FTBFS bug exposed by the CFLAGS changes.
Checksums-Sha1:
 4ffc76fdb0543bb1f35f3ff0790fe90f373b6cc7 1732 gdome2_0.8.1+debian-9.dsc
 6cfbab65678e3c3291542cc001dd5fae6e3d5f87 11328 gdome2_0.8.1+debian-9.debian.tar.xz
 ed9f7779093b99769dbb0dc1feb38ebebb19fee6 7248 gdome2_0.8.1+debian-9_source.buildinfo
Checksums-Sha256:
 f969d3486e99b00217d36d09c126882ac2a093a081aad2cb74c97119644e0838 1732 gdome2_0.8.1+debian-9.dsc
 2dc55a18825e48e7c720e46ca1b8f6b85c0628f8b0cd5f233034f153354bc870 11328 gdome2_0.8.1+debian-9.debian.tar.xz
 f0f8d32591ad9d66ee934a0feeb86ef85220a1cd8735398313a1b5b71835f4e2 7248 gdome2_0.8.1+debian-9_source.buildinfo
Files:
 25a8f08bc192cea2367b1826beb57d45 1732 libdevel optional gdome2_0.8.1+debian-9.dsc
 13411cb7193003cbea870bd78d04a76c 11328 libdevel optional gdome2_0.8.1+debian-9.debian.tar.xz
 dd63ebce4e929d5f7598a91b07c1a8a8 7248 libdevel optional gdome2_0.8.1+debian-9_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmKyz78QHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFEFgC/4hO6Ql177sbis3haJS17UuoYPihMaPYiiW
5QOJNE7cm1bdFnEvtZ4QaKyJa3TW/gVKFGUjitFr5626q10XfmoR6uQIqioOpihL
9jSVu2p5eLMbqRRNtzQr34F1h54YC5u+sIRw4SAUpGmfm2JUPCA4cqzGXxMCA3iC
1t64n+hrnk5Jp0LoZ456J/1G37ZqGRWcfyrHAyOxV6PAuDC2d5gOcUGvczPKDk2u
v6iiS05dPYNSIqdfxEc+TUC37erp4wQIJM2f2W3maTy/rgyMTq86C4ZQ2bkdvXQh
kpxojHY3fF1xZG1nxI9ZSZqKxjQG4FW9ZX83EVr4AWRPQ782qSphrdVtwSjM2RXm
35/7MXJQRrjENGfQ5aqgejNDSK1yrY+fYA2zPYaNbQS1YcJ2jMC0lBPI32DEpGUF
FlrHXDc1EQbrLEKGkle9IMCH4ktxn4rM7nCFuU6GCRH4hrxF8mItuk83fG0ZXeYT
LTNQQMuUMk5dY4x3KwkXTu/83sdgWiI=
=BfQS
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: