[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#944131: marked as done (splitpatch: please make the build reproducible)

Your message dated Tue, 05 Nov 2019 02:40:32 +0000
with message-id <E1iRolk-000D7D-6K@fasolo.debian.org>
and subject line Bug#944131: fixed in splitpatch 1.0+20190128+git3b2edf2-2
has caused the Debian Bug report #944131,
regarding splitpatch: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
944131: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944131
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: splitpatch
Version: 1.0+20190128+git3b2edf2-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
splitpatch could not be built reproducibly.

This is because my previous patch used $$(shell …) instead of $(shell
…) (note the change of number of dollar signs...) so that we were
still embedding today's date into the pod2man --center argument.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/reproducible-build.patch	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/reproducible-build.patch	2019-11-04 10:30:30.092883126 -0800
@@ -0,0 +1,18 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2019-11-04
+
+--- splitpatch-1.0+20190128+git3b2edf2.orig/man/pod2man.mk
++++ splitpatch-1.0+20190128+git3b2edf2/man/pod2man.mk
+@@ -39,9 +39,9 @@ MANSECT		?= 1
+ 
+ DATE_FMT = %Y-%m-%d
+ ifdef SOURCE_DATE_EPOCH
+-PODCENTER	?= $$(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)")
++PODCENTER	?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)")
+ else
+-PODCENTER	?= $$(date "$(DATE_FMT)")
++PODCENTER	?= $(date "$(DATE_FMT)")
+ endif
+ 
+ # Directories
--- a/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/series	2019-11-04 10:30:28.792869453 -0800
@@ -0,0 +1 @@
+reproducible-build.patch

--- End Message ---
--- Begin Message --- 
Source: splitpatch
Source-Version: 1.0+20190128+git3b2edf2-2

We believe that the bug you reported is fixed in the latest version of
splitpatch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 944131@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thiago Andrade Marques <thmarques@gmail.com> (supplier of updated splitpatch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 Nov 2019 20:37:29 -0300
Source: splitpatch
Architecture: source
Version: 1.0+20190128+git3b2edf2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Thiago Andrade Marques <thmarques@gmail.com>
Closes: 944131
Changes:
 splitpatch (1.0+20190128+git3b2edf2-2) unstable; urgency=medium
 .
   * QA upload.
   * debian/control:
       - Added 'Rules-Requires-Root: no' in source stanza.
       - Bumped Standards-Version to 4.4.1.
   * debian/copyright: added rights for Thiago Andrade Marques.
   * debian/patches/010_reproducible-build.patch: added to
       fix an unreproducible condition. Thanks to Chris Lamb
       <lamby@debian.org>. (Closes: #944131)
   * debian/salsa-ci.yml: added to provide CI tests for Salsa.
Checksums-Sha1:
 795c0b70f391f9cc00a8556d5740ae3a93f18e3c 2016 splitpatch_1.0+20190128+git3b2edf2-2.dsc
 f44bf056d1a590866d95f66a765b34fae83117d7 7016 splitpatch_1.0+20190128+git3b2edf2-2.debian.tar.xz
 0a8571b451c42dc1192b81209d0911abbca26326 5262 splitpatch_1.0+20190128+git3b2edf2-2_source.buildinfo
Checksums-Sha256:
 fcabe93152c19cf660d63abadaffc66d1d091d7df27088ca17b793d959b8f39b 2016 splitpatch_1.0+20190128+git3b2edf2-2.dsc
 c8800da03d91f7087e79fa4e83cc76dee625f920a562daa5326dc466a10987f6 7016 splitpatch_1.0+20190128+git3b2edf2-2.debian.tar.xz
 ac46d48f44a568782d4164fef6186fe22ab3d650ec66efa63d0d775a63592312 5262 splitpatch_1.0+20190128+git3b2edf2-2_source.buildinfo
Files:
 a4bc38f60ece20a56fd864575a18ab24 2016 text optional splitpatch_1.0+20190128+git3b2edf2-2.dsc
 295490829e5431f91a946c1ea36a5fa2 7016 text optional splitpatch_1.0+20190128+git3b2edf2-2.debian.tar.xz
 5777fb079b816e9d1627184deacb0bc2 5262 text optional splitpatch_1.0+20190128+git3b2edf2-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAl3A1kUACgkQ3mO5xwTr
6e+Xvw//bNtShFp3uDvKbA9Cuua/obIjWRPz0JMPYygO2ByoadPABcfWVSxYdxPF
5w25UPHyC+AE/mpobOUin0aD9GLGei6vfbGV9ZKtXJEYYCa/9q/PUIMPrTTW5ijB
H+8gzVvuifVUur0ozVSZpKYRl26BhnFK/OYJvs5XIdeFGD20/m9bpAaDCZUo7gCn
Lnl1LfAZsjOeb+Q1+Mrz2hfcPO/DQIc8/vGrzb1+SOFyl3jokDzTiMT9poFx+liZ
241mZ9mae5mZICZ+OPm5z0sU1sAQiLf1gr/2qj4FhHz3ZGr50JNb7iY7bpy2szDR
AZs5xB+QWThnMRWFW7tboQm8vCwxpNcMSQ8h65Se5wfyI6baJQ4WljpfWOguRCdv
OZ2SY3SNhEzB6C3uPBmToLOgnu79Byi138J1SMzhr5p3NjKCYQbqiwbYgUukQcft
k4OZ6HEwSEbccYdaVLf6wvPhlFNefNBEq8bwaZq09/NRIA0fNkD434iJFnLqACW+
3EMLbQo0kE3m91FOj/4Qu0cwh7MSBYSqig9avbSHx71Z4O/wp8vNDkPXfXwtWIRU
OSZKd8Rgl3xqdAGKNV+O1bdyb0UYYQmUuegvvg/YHcH37Ewaxrp2B50pLQmZU9En
4tfeqcDXJq0V/h/8IAaqMzGiwsUzLr7ctZ0L0icyfxRmCzCiD6A=
=NLZm
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: