[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#782232: marked as done (zpaq: please make the build reproducible)

Your message dated Sat, 01 Oct 2016 23:29:08 +0000
with message-id <E1bqTiO-0001vr-Ct@franck.debian.org>
and subject line Bug#782232: fixed in zpaq 1.10-3
has caused the Debian Bug report #782232,
regarding zpaq: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
782232: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782232
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: zpaq
Version: 1.10-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-CC: reproducible-builds@lists.alioth.debian.org

Hi!

While working on Debian's “reproducible builds” effort [1], we have
noticed that zpaq doesn't build reproducibly.
It embeds the current date into the manpage.

The attached patch fixes this by using the last changelog date
as a timestamp that will be embedded.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds



















diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..1709a04
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,16 @@
+Author: Reiner Herrmann <reiner@reiner-h.de>
+Description: Remove timestamp from binary to enable reproducible builds.
+
+Index: zpaq-1.10/zpaq.cpp
+===================================================================
+--- zpaq-1.10.orig/zpaq.cpp
++++ zpaq-1.10/zpaq.cpp
+@@ -4556,7 +4556,7 @@ void run(int argc, char** argv) {
+ // Print help message and exit
+ void usage() {
+   printf("ZPAQ v1.10 archiver, (C) 2009, Ocarina Networks Inc.\n"
+-    "Written by Matt Mahoney, " __DATE__ ".\n"
++    "Written by Matt Mahoney.\n"
+     "This is free software under GPL v3, http://www.gnu.org/copyleft/gpl.html\n";
+     "\n"
+     "To compress to new archive: zpaq [opnsitqv]c[F[,N...]] archive files...\n"
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..b2026fe
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+reproducible_build.patch
diff --git a/debian/pod2man.mk b/debian/pod2man.mk
index 64bc797..f878a28 100644
--- a/debian/pod2man.mk
+++ b/debian/pod2man.mk
@@ -34,9 +34,10 @@ endif
 PACKAGE		?= package
 
 # Optional variables to set
+BUILD_DATE	?= $$(dpkg-parsechangelog -S Date -lchangelog)
 MANSECT		?= 1
 PODCENTER 	?= User Commands
-PODDATE		= $$(date "+%Y-%m-%d")
+PODDATE		= $$(date -u "+%Y-%m-%d" -d "$(BUILD_DATE)")
 
 # Directories
 MANSRC		=

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: zpaq
Source-Version: 1.10-3

We believe that the bug you reported is fixed in the latest version of
zpaq, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 782232@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated zpaq package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 01 Oct 2016 23:33:07 +0100
Source: zpaq
Binary: zpaq
Architecture: source amd64
Version: 1.10-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 zpaq       - maximum reference compressor for ZPAQ open standard
Closes: 782232
Changes:
 zpaq (1.10-3) unstable; urgency=medium
 .
   * QA upload.
   * Make the build reproducible. Thanks to Reiner Herrmann
     <reiner@reiner-h.de> for the patch. (Closes: #782232)
Checksums-Sha1:
 eaadc39cbb3883d33ef97232aa0eb73a469cca07 1758 zpaq_1.10-3.dsc
 9fa5cfb4605822cfbfdba7792d967fdd11d9047b 66852 zpaq_1.10.orig.tar.gz
 00eaf0e9459bb9fe8df12d05e25a0492d925223b 13888 zpaq_1.10-3.debian.tar.xz
 6dbdda37312be28d15fe325b1b6c5c79df0f07c3 75762 zpaq-dbgsym_1.10-3_amd64.deb
 9fec0f72ea0fdece7385e5eefe4b2f75ee232259 51266 zpaq_1.10-3_amd64.deb
Checksums-Sha256:
 2d3a777e121d1c775199871292ff64892f6983c9742779b20163927bf3a709a8 1758 zpaq_1.10-3.dsc
 0d64aaa5ba7fac186ae5450e0a8cf6f346283c3d6fab27841b818e21f5ce78be 66852 zpaq_1.10.orig.tar.gz
 44ce828733ae56405b12d0b516b15eedff53bea30938ccd0ba89e43ec9c53021 13888 zpaq_1.10-3.debian.tar.xz
 e59b110e0676d7dfe8059ba966a98d1fa2108fc781e6eac0d7ae3ed5095ce544 75762 zpaq-dbgsym_1.10-3_amd64.deb
 33e9a3ed54ab77b382044ff6df9bacac7851e5bda0c3f3ceb60fb32059b78e66 51266 zpaq_1.10-3_amd64.deb
Files:
 9114bd1b044b755e4215655a61d98fd3 1758 utils optional zpaq_1.10-3.dsc
 f25cb07167338b43b30b81baed93ccc0 66852 utils optional zpaq_1.10.orig.tar.gz
 963464664c621d3d9f31097f9c07df19 13888 utils optional zpaq_1.10-3.debian.tar.xz
 e3e0196ac40a53a8818b0a5ad726b734 75762 debug extra zpaq-dbgsym_1.10-3_amd64.deb
 3bb849d85cff558a512529bfd63fa335 51266 utils optional zpaq_1.10-3_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX8DrgAAoJEB6VPifUMR5YqxMP/RPn7Y0gGpAy4gPJ8As0lqOl
1TjmzxBNWl/MR2idrsV8Vyy6vJUuSyWQrOjOm//sg9WfplBaFHtogAuystRRz3E7
j+CcHAmAY3OOAQazB2FXfRv//3akXs+ewHD4rMhq2BqbPEs2bGG3CU6kfGg2KSqP
0qyd6ugghmNpPa97uAf8T0qFLQRR+ywl2+3kK0BnMUVdzKQAeJsRg1s0phRIpW/1
OI7WENJvfPtK/kEcD1sT0aTI/KBYNCOx4W8zKnglzGH9+yWZ6ZzfRxj+Q9hLe0Xp
r/uok0ZLS7M1JuSzAOmgV/Z/GW94CPYhJKWOZef5nLCmgqBOIJvagwdhXVEdFG97
XfUuEGug0C2EaAgtzvV5fRi59qu6r8PbLPuBUXTH7dDE4tdq+LBznGOo7e2NvT5c
IqzWgQBhMoQmziEJIe4pglYuaNzgXzehJCDgmnY/lgsS8YUHForHwxPjV0+svB7d
yKNOq8n2PEocGD8i85ZQP9BLThBodlxEmWCtzMBk/EO7Dlr2ZbS30ogfXanA5lB2
rImkMPomWuI9KANmw+WCYY3/Q5BC0sXbjR9/yCxGEGDCE2+Ea2h0yfZXE2mRSVQ6
Mzcz0OAJ5qVRU61ReiRsiNIT4MOUfmcC1n8z4egfAjbRkq+79lDFh3o0m1Sg8btp
SakZSmLPBDYzVB3ln4bD
=7Qxx
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: