[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#633555: marked as done (toshset: novatel patch blocks suspend if device doesn't exist)

Your message dated Sun, 11 Dec 2011 23:35:22 +0000
with message-id <E1RZsvS-00009O-7S@franck.debian.org>
and subject line Bug#633555: fixed in toshset 1.76-2
has caused the Debian Bug report #633555,
regarding toshset: novatel patch blocks suspend if device doesn't exist
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
633555: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633555
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: toshset
Version: 1.76-1
Severity: important
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch

After fixing a pm-utils bug,
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633147, that ensured
that suspend was never inhibited it was discovered that toshset doesn't
check for the existence of a device before trying to modify it.
Subsequently, if the device doesn't exist it returns a non-zero exit
code which thereby inhibits suspend.  The following patch fixes that.


In Ubuntu, the attached patch was applied to achieve the following:

to allow users to suspend / hibernate again.

  * 08_novatel_3g_suspend.patch: allow suspend / hibernate if device doesn't
    exist


Thanks for considering the patch.


-- System Information:
Debian Release: squeeze/sid
  APT prefers natty-updates
  APT policy: (500, 'natty-updates'), (500, 'natty-security'), (500, 'natty')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-8-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru toshset-1.76/debian/patches/08_novatel_3g_suspend.patch toshset-1.76/debian/patches/08_novatel_3g_suspend.patch
--- toshset-1.76/debian/patches/08_novatel_3g_suspend.patch	2011-03-14 12:34:26.000000000 -0700
+++ toshset-1.76/debian/patches/08_novatel_3g_suspend.patch	2011-07-08 18:36:01.000000000 -0700
@@ -1,8 +1,10 @@
 Author: Roberto C. Sanchez <roberto@connexer.com>
 Description: Script that was omitted from the release by upstream
---- /dev/null
-+++ trunk/novatel_3g_suspend
-@@ -0,0 +1,30 @@
+Index: toshset-1.76/novatel_3g_suspend
+===================================================================
+--- /dev/null	1970-01-01 00:00:00.000000000 +0000
++++ toshset-1.76/novatel_3g_suspend	2011-07-08 18:35:53.000000000 -0700
+@@ -0,0 +1,34 @@
 +#! /bin/sh
 +
 +# This script puts the Novatel 3G modem in Toshiba Portege R500 to USB
@@ -24,6 +26,10 @@
 +BUS=2
 +DEVICE=2
 +
++if [ ! -x /sys/bus/usb/devices/${BUS}-${DEVICE}/power/level ]; then
++    exit 0
++fi
++
 +case $1 in
 +     suspend|suspend_hybrid|hibernate)
 +	echo suspend > /sys/bus/usb/devices/${BUS}-${DEVICE}/power/level
@@ -33,8 +39,10 @@
 +	:
 +        ;;
 +esac
---- trunk.orig/Makefile.in
-+++ trunk/Makefile.in
+Index: toshset-1.76/Makefile.in
+===================================================================
+--- toshset-1.76.orig/Makefile.in	2011-07-08 18:35:02.000000000 -0700
++++ toshset-1.76/Makefile.in	2011-07-08 18:35:03.000000000 -0700
 @@ -308,7 +308,7 @@
  	for program in $(PROGRAMS); do \
  		$(BININSTALL) $$program $(DESTDIR)/$(BINDESTDIR)/$$program;\

--- End Message ---
--- Begin Message --- 
Source: toshset
Source-Version: 1.76-2

We believe that the bug you reported is fixed in the latest version of
toshset, which is due to be installed in the Debian FTP archive:

toshset_1.76-2.debian.tar.gz
  to main/t/toshset/toshset_1.76-2.debian.tar.gz
toshset_1.76-2.dsc
  to main/t/toshset/toshset_1.76-2.dsc
toshset_1.76-2_amd64.deb
  to main/t/toshset/toshset_1.76-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 633555@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paolo Rotolo <paolorotolo@ubuntu-it.org> (supplier of updated toshset package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 11 Dec 2011 18:28:25 +0100
Source: toshset
Binary: toshset
Architecture: source amd64
Version: 1.76-2
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Paolo Rotolo <paolorotolo@ubuntu-it.org>
Description: 
 toshset    - Access much of the Toshiba laptop hardware interface
Closes: 633555
Changes: 
 toshset (1.76-2) unstable; urgency=low
 .
   * QA upload.
   * Update 08_novatel_3g_suspend.patch: allow suspend / hibernate if
     device doesn't exist, otherwise system may not suspend properly.
     Thanks Brian Murray for the patch (Closes: #633555).
   * Bump Standards-Version to 3.9.2.
Checksums-Sha1: 
 634be22c6d8b88e36caecb9ef6c65f1b83e2751d 1769 toshset_1.76-2.dsc
 3eb9ec5fa36695591e0fc24da2ae7ed5cee2da26 33675 toshset_1.76-2.debian.tar.gz
 75947fdccd3bb69595acf0a509b47c49e08674c5 70234 toshset_1.76-2_amd64.deb
Checksums-Sha256: 
 65d5e1f545528199efc87abf6683657b598ae417322d934f6a8199f4879cee72 1769 toshset_1.76-2.dsc
 d5f2177ea82056b5319c5ec8d3d0a834977c1d1c3c48a862be6d8423cb918c87 33675 toshset_1.76-2.debian.tar.gz
 82f59c5fa9292d252e9d590e5cc900187a708fd50637268741e25799ac4e9c11 70234 toshset_1.76-2_amd64.deb
Files: 
 7bf7f908605d683540eead42ac87b469 1769 utils optional toshset_1.76-2.dsc
 c5f13e5b1b8b4b47beda609431297aa0 33675 utils optional toshset_1.76-2.debian.tar.gz
 23a058966a20cc9313b3154f3525a3ae 70234 utils optional toshset_1.76-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO5TqBAAoJEEkIatPr4vMfElcP/0AGeRgbeaBo+Tooh5O0yx7E
T9lCViFMSw55K0exzgyj+zxJiQRxfgGy12c8kRwWwIpuK0ZahGfQ42YG3jQ5SP+/
lDgw8n3BOnt0TxZrVBEZs1BkrXE1TCLZxfFlY0FuQiit1ETHPgDik4ZxVnARVMBA
p6dHMsOq2J+OVY+u2FfsC4vNGV/BlCNOyKkLGZEpQjnx8jWCMOyvphYk2VZpwmfI
I2/ibvYSnEE0ZIkDkPb50tNJqmlTFXuYW1U4XXHJeD0QrkgroXaI6W/bc2SjhKu7
yQBS0O42/N/jBW15vKbCmgNJJnNN/vw4OIm1axAzDKVc79mKpVlYirkDrVYAJIUX
M3oC7x7+U9RMH3vb7WvhuHNbl4oDZd5fpNm389JvXuUAYSOoT1uoi/oQ8N+J210T
SQtgV7Le/zShks404S3dBMo+CAxr32BZbKAjSL2WyAL5c4lDvMEXjDEpUfsMQwvW
yglMu0F/mHxD/vENXSpb1RjO7LTK5iLP7Nc7uw09+pibnWvTvk2TeOR+ve47gr+A
wP7cJOOebi0ikx+YNEjPyGPwerMiBGCWro1vxYv0GMZ6OawEtLgB5N9NOUip6GeV
ceoTqz0BWg1VHmCllOtswtCpi1ogzx6001fpRM0XSqJJej/vo1PrliANZHi2MfMX
oPsgzyTDlDigxYjZUzrz
=tGnn
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: