[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: python-keyring 1.4-1



On Jun 18, 2013 7:33 PM, "Sebastian Ramacher" <sramacher@debian.org> wrote:
>
> On 2013-06-18 18:21:27, Dmitry Shachnev wrote:
> > >> > What's the status of all the other tests? Many tests are skipped because
> > >> > of missing dependencies.
> > >>
> > >> Gnome-keyring-daemon refuses to run in xvfb. As I do not know other
> > >> Secret Service implementations, it's currently impossible to test
> > >> GNOME and Secret Service backends (libsecret's upstream testsuite has
> > >> some code for mocking Secret Service, but I didn't yet have time to
> > >> test it).
> > >
> > > If we can't run them reliably I'd rather see them disabled.
> >
> > These tests either succeed or are skipped — i.e. do not affect the
> > build. Why should we disable them?
>
> Because they cause the package to FTBFS if python-secretstorage is
> installed and there's no gnome-keyring or dbus session available.

I've fixed this in upstream SecretStorage and added a temporary patch to python-keyring to workaround this failure.

--
Dmitry Shachnev


Reply to: