[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#190749: marked as done (debian-policy: /etc/init.d scripts example 'test -f program-executed-later-in-script' should be 'test -x')



Your message dated Sun, 03 Aug 2003 12:16:33 -0500
with message-id <87brv6mzke.fsf@glaurung.green-gryphon.com>
and subject line Bug#190749: debian-policy: /etc/init.d scripts example 'test -f program-executed-later-in-script' should be 'test -x'
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at maintonly) by bugs.debian.org; 25 Apr 2003 14:21:23 +0000
>From pierre.thierry@moine-fou.org Fri Apr 25 09:21:22 2003
Return-path: <pierre.thierry@moine-fou.org>
Received: from astrasbourg-206-1-5-251.abo.wanadoo.fr (imperatrice.arcanes) [80.13.114.251] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 19944o-0001hE-00; Fri, 25 Apr 2003 09:21:22 -0500
Received: by imperatrice.arcanes (Postfix, from userid 1000)
	id EC0A68E091; Fri, 25 Apr 2003 16:21:56 +0200 (CEST)
Date: Fri, 25 Apr 2003 16:21:56 +0200
From: Pierre THIERRY <pierre.thierry@moine-fou.org>
To: Debian Bug Tracking System <maintonly@bugs.debian.org>
Subject: debian-policy: /etc/init.d scripts example 'test -f program-executed-later-in-script' should be 'test -x'
Message-ID: <20030425142156.GA30750@imperatrice.arcanes>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH"
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-Reportbug-Version: 1.50
X-Operating-System: Linux 2.4.18-686 i686
X-Uptime: 228 days
X-Sheldon-Has-Said: Mange ton =?iso-8859-1?B?Y+Jj4uI=?= !
Delivered-To: maintonly@bugs.debian.org
X-Spam-Status: No, hits=-24.9 required=4.0
	tests=BAYES_01,HAS_PACKAGE,PATCH_UNIFIED_DIFF,PGP_SIGNATURE_2,
	      USER_AGENT_MUTT
	autolearn=ham version=2.53
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp)


--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: debian-policy
Version: 3.5.6.1
Severity: minor
Tags: patch

In the 10.3.2 section, a example line to test if the program to execute
does exist is given, but it only tests if the file exists, not if it is
executable.

--- policy.sgml	2003-04-19 12:33:14.000000000 +0200
+++ policy.sgml.corrected	2003-04-25 16:13:36.000000000 +0200
@@ -4762,7 +4762,7 @@
 	    should include a <tt>test</tt> statement at the top of the
 	    script, like this:
 	    <example compact=3D"compact">
-test -f <var>program-executed-later-in-script</var> || exit 0
+test -x <var>program-executed-later-in-script</var> || exit 0
 	    </example>
 	  </p>
=20

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux imperatrice.arcanes 2.4.18-686 #1 Sun Apr 14 11:32:47 EST 200=
2 i686
Locale: LANG=3Dfr_FR@euro, LC_CTYPE=3Dfr_FR@euro

Versions of packages debian-policy depends on:
ii  fileutils                     4.1-10     GNU file management utilities

--=20
mailto:pierre.thierry@moine-fou.org
OpenPGP 0xD9D50D8A

--ReaqsoxgOBHFXBhH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+qUSExe13INnVDYoRAjCXAJ4nSKA2rzlh22evNi+Ergut/dpAPgCfftjt
pHNP3Gh/gl/kHL7O3iYI0SU=
=ijX5
-----END PGP SIGNATURE-----

--ReaqsoxgOBHFXBhH--

---------------------------------------
Received: (at 190749-done) by bugs.debian.org; 3 Aug 2003 17:23:25 +0000
>From srivasta@debian.org Sun Aug 03 12:23:23 2003
Return-path: <srivasta@debian.org>
Received: from host-12-107-230-171.dtccom.net (glaurung.green-gryphon.com) [12.107.230.171] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19jMZm-0006lf-00; Sun, 03 Aug 2003 12:23:22 -0500
Received: from glaurung.green-gryphon.com (srivasta@localhost [127.0.0.1])
	by glaurung.green-gryphon.com (8.12.9/8.12.9/Debian-5) with ESMTP id h73HGXNA021752
	for <190749-done@bugs.debian.org>; Sun, 3 Aug 2003 12:16:34 -0500
Received: (from srivasta@localhost)
	by glaurung.green-gryphon.com (8.12.9/8.12.9/Debian-5) id h73HGX21021748;
	Sun, 3 Aug 2003 12:16:33 -0500
X-Authentication-Warning: glaurung.green-gryphon.com: srivasta set sender to srivasta@debian.org using -f
X-Mailer: emacs 21.3.2 (via feedmail 8 I)
To: 190749-done@bugs.debian.org
Subject: Re: Bug#190749: debian-policy: /etc/init.d scripts example 'test -f
 program-executed-later-in-script' should be 'test -x'
References: <E199uBO-0003xL-00@gondolin.me.apana.org.au>
From: Manoj Srivastava <srivasta@debian.org>
Organization: The Debian Project
X-URL: http://www.debian.org/%7Esrivasta/
User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux)
 (i386-pc-linux-gnu)
Mail-Copies-To: nobody
X-Face: #q.#]5@vq!Jz+E0t_/;Y^gTjR\T^"B'fbeuVGiyKrvbfKJl!^e|e:iu(kJ6c|QYB57LP*|t
 &YlP~HF/=h:GA6o6W@I#deQL-%#.6]!z:6Cj0kd#4]>*D,|0djf'CVlXkI,>aV4\}?d_KEqsN{Nnt7
 78"OsbQ["56/!nisvyB/uA5Q.{)gm6?q.j71ww.>b9b]-sG8zNt%KkIa>xWg&1VcjZk[hBQ>]j~`Wq
 Xl,y1a!(>6`UM{~'X[Y_,Bv+}=L\SS*mA8=s;!=O`ja|@PEzb&i0}Qp,`Z\:6:OmRi*
Date: Sun, 03 Aug 2003 12:16:33 -0500
In-Reply-To: <E199uBO-0003xL-00@gondolin.me.apana.org.au> (Herbert Xu's
 message of "Mon, 28 Apr 2003 07:59:38 +1000")
Message-ID: <87brv6mzke.fsf@glaurung.green-gryphon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: 190749-done@bugs.debian.org
X-Spam-Status: No, hits=-14.4 required=4.0
	tests=BAYES_20,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,
	      REPLY_WITH_QUOTES,USER_AGENT_GNUS_UA,X_AUTH_WARNING
	autolearn=ham version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20 (1.174.2.15-2003-03-30-exp)

On Mon, 28 Apr 2003 07:59:38 +1000, Herbert Xu <herbert@gondor.apana.org.au> said: 

> Pierre THIERRY <pierre.thierry@moine-fou.org> wrote:

>> In the 10.3.2 section, a example line to test if the program to
>> execute does exist is given, but it only tests if the file exists,
>> not if it is executable.

> There is no point in test executability since the test is meant to
> determine whether the package has been removed or not.

	I tend to agree. Also, arguments have been made that this
 prevents confusion when the init scripts do not work, when someone in
 the past had turned the exucute bit off to prevent execution, but
 forgot to tell the current admin.

	In any case, this did not garner any support, and the current
 policy works well enough for what it intends to do, so I am closing
 this report.

	manoj
-- 
"They make a desert and call it peace." Tacitus (55?-120?)
Manoj Srivastava   <srivasta@debian.org>  <http://www.debian.org/%7Esrivasta/>
1024R/C7261095 print CB D9 F4 12 68 07 E4 05  CC 2D 27 12 1D F5 E8 6E
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C



Reply to: