Re: Request for review - libgd-graph-perl - v1.56
On Tue, 2023-05-23 at 14:25 +0200, gregor herrmann wrote:
On Tue, 25 Apr 2023 13:05:14 +1200, Andrew Ruthven wrote:
I've updated libgd-graph-perl to v1.56, can I please get it reviewed?
Yes, and sorry for the delay.
No problem.
One thing I haven't done is remake the upstream tarball to remove
samples/logo.gif which was done for the 1.54 release. Seems like a lot
of effort to save a 2.7 kB file. However, if the preference is to
continue to remove it, I can do that. The presence of this file does
cause this lintian error currently:
E: libgd-graph-perl source: source-ships-excluded-file samples/logo.gif
[debian/copyright:8]
I didn't want to remove the exclusion before having this reviewed.
I wonder how you manged not to exlcude the file :)
as both dpt-import-orig (and the underlying gbp-import-orig) should,
with d/watch and d/copyright, exclude samples/logo.gif and create a
15.56~ds-1 version.
Looks like I most likely downloaded the tarball manually rather than
use uscan.
I'm not totally sure why samples/logo.gif was excluded, the various
notes say "avoiding/excluding pre-generated files". Either there were
worries about license or more likely preferred form f modification,
or problems when building twice. In any case, I'd personally stick
with the exclusion.
I have made a 1.56~ds orig tarball without logo.gif and pushed it to Salsa.
BTW, first time I've used the dpt tool, really nice.
I'm glad you like it; OOC: which subcommands did you use?
Ah, from looking at the commit messages it was dpt-fixup :)
That and also now gen-itp and salsa pushrepo (to create new repos as well).
I pushed some small fixes, cf. git log …
Ta.
What's missing in the end is that you either add yourself to
Uploaders or add "Team upload." as the first line in d/changelog.
I'm currently a DM (just applied to become a DD), so even if I add myself to
Uploaders, I cant upload. I have added "Team upload." to d/changelog.
Cheers,
Andrew
--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |
Reply to: