[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#948120: marked as done (libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES)

Your message dated Thu, 09 Jan 2020 17:40:52 +0000
with message-id <E1ipbng-0008nT-Bz@fasolo.debian.org>
and subject line Bug#948120: fixed in libreoffice 1:6.4.0~rc2-1
has caused the Debian Bug report #948120,
regarding libreoffice: Incorrect conditional test to enable BUILD_NOGUI_PACKAGES
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
948120: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=948120
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libreoffice
Severity: normal
User: debian-powerpc@lists.debian.org
Usertags: ppc64

Hi!

The build on ppc64 currently fails because debian/rules tries to execute some
script code on ppc64 which is relevant for the OOO_NOGUI_ARCHS in debian/rules.

Specifically, the build fails with:

# remove lib*uilo.so in --nogui
find debian/libreoffice-*-nogui/usr/lib/libreoffice/program/lib*uilo.so -exec rm {} \;
# and (no UI, so not needed) not needed .desktop files
find debian/libreoffice-*-nogui/usr/share/applications/*.desktop -exec rm {} \;
find: ‘debian/libreoffice-*-nogui/usr/share/applications/*.desktop’: No such file or directory
make: *** [debian/rules:2699: debian/stampdir/install-arch] Error 1

I haven't verified it, but my suspicion is that the following conditional test is
incorrect as the function findstring will match "ppc64" in OOO_NOGUI_ARCHS if
it contains "ppc64el":

ifeq "$(ENABLE_GUI)" "y"
  ifneq (,$(findstring $(DEB_HOST_ARCH),$(OOO_NOGUI_ARCHS)))
    BUILD_NOGUI_PACKAGES=y
  endif
else

So, I suggest to use the function "filter" instead of "findstring" to fix this
conditional test.

It's probably a good idea to check other instances of "findstring" in debian/rules
and make sure it does not match on undesired substrings.

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---
--- Begin Message --- 
Source: libreoffice
Source-Version: 1:6.4.0~rc2-1

We believe that the bug you reported is fixed in the latest version of
libreoffice, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 948120@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated libreoffice package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 08 Jan 2020 17:22:52 +0000
Source: libreoffice
Architecture: source
Version: 1:6.4.0~rc2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 948120
Changes:
 libreoffice (1:6.4.0~rc2-1) unstable; urgency=medium
 .
   * New upstream release candidate
 .
   * debian/rules:
     - stop special-casing ure, uno-libs-private, libuno* epoch-wise to avoid
       confusion (especially since it was missed to apply that special-casing to
       lib*-java anyways)
     - use filter for setting BUILD_NOGUI_PACKAGES and add ppc64 to OOO_NOGUI_ARCHS
       (closes: #948120)
     - add missing dh_python3 call for python3-access2base
    * debian/control.*.in:
      - make libjuh-java Depends: ure since it loadLibrary()'s libjuh.so;
        same with libjurt-java (libjava_uno.so)
      - add some explicit dependencies on the new java packages to where they are
        mentioned in Class-Path:
      - suggest odbc-mdbtools instead of just mdbtools
      - remove obsolete alternatives from ${java-runtime-depends} and suggest that
        instead of java5-runtime in ure
    * debian/rules, debian/control.in:
      - make libofficebean-java arch-dep and install libofficebean.so there
        (into /usr/lib/jni with a symlink from /usr/lib/libreoffice/program);
        make libreoffice-officebean a transitional package for libofficebean-java
Checksums-Sha1:
 ac01dc2da6549921cc140c2d605c663f07171be5 21348 libreoffice_6.4.0~rc2-1.dsc
 492871d8c77a0fd6079f8f9ea867cba082ab891f 87696948 libreoffice_6.4.0~rc2.orig-helpcontent2.tar.xz
 841a7cdc2d84e89748675f0fece2770b2af31b52 171340940 libreoffice_6.4.0~rc2.orig-translations.tar.xz
 619101ef90129c7d918702aaccb30e07d77a6eb4 229028564 libreoffice_6.4.0~rc2.orig.tar.xz
 7b5f26f7c08d4f7edbca240b8d7dc7707f5719cb 833 libreoffice_6.4.0~rc2.orig.tar.xz.asc
 57cb767c7a85d7739a3dac46ea661138003ac4dc 10900792 libreoffice_6.4.0~rc2-1.debian.tar.xz
 6e5a7b9a370c6aa87f5934d44c38be49b70968db 37099 libreoffice_6.4.0~rc2-1_source.buildinfo
Checksums-Sha256:
 c20b591b05210b8ad8f6566606ded556e3a43a8beefdf7cd397a45126da67433 21348 libreoffice_6.4.0~rc2-1.dsc
 06a3fbf918c2d15d6a39942296a82351f1dd5ee851ab7f4661710ba6f21e096d 87696948 libreoffice_6.4.0~rc2.orig-helpcontent2.tar.xz
 1f5459204ba79f913f15b56a29a772eaaeab0e36c9a40267ad4500b5af43b7ee 171340940 libreoffice_6.4.0~rc2.orig-translations.tar.xz
 2a517fcf4ba90566f079e1f429a02b8fcd20924a0fab0da1aab4e255857225a5 229028564 libreoffice_6.4.0~rc2.orig.tar.xz
 72e2da80700d4acf6ff417a4689a79e3ab361d63b727ff9ec0e58fbce3df2164 833 libreoffice_6.4.0~rc2.orig.tar.xz.asc
 c51e3c154d359d662c21a5d21b51396af11292e381a95c2fcb94ae4892f5faf4 10900792 libreoffice_6.4.0~rc2-1.debian.tar.xz
 9cbc5f5c194eeae0c76e5b9236c2f64bc0d7a3394b798c0f6879cd6932b9c184 37099 libreoffice_6.4.0~rc2-1_source.buildinfo
Files:
 ea8b2f3f8dc02253a0a8bc9c7a04c2ef 21348 editors optional libreoffice_6.4.0~rc2-1.dsc
 fff00135c187232ed9f1b304959ef17c 87696948 editors optional libreoffice_6.4.0~rc2.orig-helpcontent2.tar.xz
 bbaf88a83e9b97e0af5f1b5ae2be755e 171340940 editors optional libreoffice_6.4.0~rc2.orig-translations.tar.xz
 2836f1ebdba33620df7281571d906620 229028564 editors optional libreoffice_6.4.0~rc2.orig.tar.xz
 c98acd1acfc6535cf17221883e67699f 833 editors optional libreoffice_6.4.0~rc2.orig.tar.xz.asc
 cb37ecdaadac621e82a27283f7baf81a 10900792 editors optional libreoffice_6.4.0~rc2-1.debian.tar.xz
 7eac11beb8643e4dbb399d4e304ca7fd 37099 editors optional libreoffice_6.4.0~rc2-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAl4XXV8QHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cGRZD/9tJIPAOt6rrviGHlqmDo2UvKF1LhTQ0KKJ
SCrbUiin88VS8ILgTkWEDMrhDY21VqQL/qJfkHiD1nPWFfByIycZxQsaQ9EasjFd
yHIIG5vYhGcPC81MFND7pBHpq25RWQXJr2Zg7BgM/S5UREersVoy+8SAKZMjxV5c
lMHV4dg1i3btjinLD4+s/83XehHf0hU8HV6ZOhXXa41jFQI3CA0jVRcsp/lZBuhc
m/IKT4h/IhzHvcao0YmGg2boLtAjwRRDbHLgZ+7tK/A8vGzQQ47QVm39LrDOVPJ5
JglOSnWBSO5LBGEcHuEfA3Y37SFfd2oMkcPX/9UxTZykLJTWAS6VIKPmAeQkxsE9
fN7LDKRDQnzVzXmzoZxkmAf8MlwW9N2qgTOyjzQNfwEOBh0Y+Sz9Y0iqcy6lO+/F
Y0OKg5eMzOEFrJz+kOtj8ZI3bsG1b9Yd3tqGmaE3A9lepAY5kZEOguig9AfbySx8
UadjR5xg0+NaloKabxhM88/9SbIakYpiIKcI7bikAzctphSGfiAakjBk6KcIPVnJ
pjv51iZ9hNFKS4NCgiBahPYvI1EhS0rsdvptdHajfURN0TIpVA3rY5x7fAEqLYWx
XgR+tyO8Zz11ZFgDnHF9v5VaBFOmm1Syi7qu1SrpDAb9Qas7yeuo7g9YYkfLi8Vr
hOGTVPO2GQ==
=VKav
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: