Re: Uploads needed
Hi Nicolas,
On Sat, Jul 23, 2016 at 10:48:16PM -0400, Nicolas Braud-Santoni wrote:
> Hi,
>
> I finally pushed a few packages updates to alioth,
> so they need a review & sponsored upload.
>
> ## mathcomp
>
> That's the largest one.
> I brought in v1.6, which is compatible with Coq 8.5 and ships ssreflect
> as part of mathcomp (closes FTBFS #813820), so the ssreflect source
> package should be deleted.
>
> I also moved the documentation to a separate package,
> and cleaned up a number of things.
I started with this one. This looks really good, there are just a few
things:
1) Concerning the patch 0001-Build-docs-*:
+ $(H) cd ../mathcomp; $(COQBIN)/coqdep -R . mathcomp $(SRC) | \
+ grep -v 'vio:' > ../htmldoc/depends
this replaces a line where the result was written to ../htmldoc/depend
(note the missing final "s"). Is this on purpose ?
Also, it seems to me that some of the modifications in the patch are
purely cosmetic (like formatting, avoiding an unnecessary cat). I don't
think that it is a good idea to do cosmetic changes in a patch, as each
modification makes it harder to carry the patch forward to new releases.
If you have minor modifications it would be better to transmit them
directly to upstream.
2) Another remark concerns the organisation of debian/rules. You now have
two Architecture=any packages, these will be build by the autobuilders.
These packages alone should be quick to compile. However, compiling the
complete packages takes freakishly long. In this case it would be really
a big gain if you could implement targets build-arch and install-arch
that only do what is necessary to build the two architecture-dependent
packages, without doing all the rest. Do you think you can do this ? This
would also allow you to move some of the Build-Dependencies into
Build-Depends-Indep.
OTOH, I do not think that it would be worth the trouble to try to take
the architecture-dependent stuff out of build-indep, as this takes
already forever anyway.
You can test for yourself building only architecture-dependent packages
using the "-B" option of git-buildpackage.
3.) % lintian *.changes
E: mathcomp source: source-is-missing htmldoc/js/cytoscape.js line length
is 849 characters (>512)
E: mathcomp source: source-is-missing htmldoc/js/dagre.js line length is
803 characters (>512)
W: mathcomp source: debhelper-but-no-misc-depends mathcomp-doc
The last one is easy to fix. Can anything be done about the first two?
> I pushed the branches as v1.6/{master,upstream,pristine-tar} on alioth.
Thanks for doing that, I have now merged these back into
master/upstream/pristine-tar.
I will look at the other packages once I am back home.
Thanks for all your work ! Cheers -Ralf.
Reply to: