[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#776643: marked as done (ocamlweb: please make the build reproducible)

Your message dated Fri, 17 Jul 2015 05:49:04 +0000
with message-id <E1ZFyW8-0007jR-LX@franck.debian.org>
and subject line Bug#776643: fixed in ocamlweb 1.39-2
has caused the Debian Bug report #776643,
regarding ocamlweb: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
776643: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776643
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ocamlweb
Version: 1.38-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that ocamlweb could not be built reproducibly.

The attached patch removes timestamps from the build system. Once
applied, ocamlweb can be built reproducibly in our current experimental
framework.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

diff -urNad ocamlweb.orig/ocamlweb-1.38/debian/rules ocamlweb/ocamlweb-1.38/debian/rules
--- ocamlweb.orig/ocamlweb-1.38/debian/rules	2015-01-30 13:04:34.226952623 +0000
+++ ocamlweb/ocamlweb-1.38/debian/rules	2015-01-30 13:14:46.145306681 +0000
@@ -1,5 +1,6 @@
 #!/usr/bin/make -f
 
+BUILD_DATE=$(shell dpkg-parsechangelog --show-field Date)
 DEB_DESTDIR=$(CURDIR)/debian/ocamlweb
 
 %:
@@ -15,7 +16,7 @@
 
 # we have decided to build this package as bytecode
 override_dh_auto_build:
-	$(MAKE) byte
+	$(MAKE) byte BUILD_DATE="$(BUILD_DATE)"
 
 # UPDATETEX: executed after installation of tex files
 override_dh_auto_install:
diff -urNad ocamlweb.orig/ocamlweb-1.38/Makefile.in ocamlweb/ocamlweb-1.38/Makefile.in
--- ocamlweb.orig/ocamlweb-1.38/Makefile.in	2015-01-30 13:04:34.226952623 +0000
+++ ocamlweb/ocamlweb-1.38/Makefile.in	2015-01-30 13:15:07.861966728 +0000
@@ -21,6 +21,7 @@
 MAJORVN=1
 MINORVN=38
 VERSION=$(MAJORVN).$(MINORVN)
+BUILD_DATE="$(shell date)"
 
 OCAMLBEST=@OCAMLBEST@
 
@@ -75,7 +76,7 @@
 
 version.ml: Makefile
 	echo "let version = \""$(VERSION)"\"" > version.ml
-	echo "let date = \""`date`"\"" >> version.ml
+	echo "let date = \""$(BUILD_DATE)"\"" >> version.ml
 
 install-indep:
 	mkdir -p $(BINDIR)

--- End Message ---
--- Begin Message --- 
Source: ocamlweb
Source-Version: 1.39-2

We believe that the bug you reported is fixed in the latest version of
ocamlweb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 776643@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mehdi Dogguy <mehdi@debian.org> (supplier of updated ocamlweb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 16 Jul 2015 19:40:36 +0000
Source: ocamlweb
Binary: ocamlweb
Architecture: source all
Version: 1.39-2
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Mehdi Dogguy <mehdi@debian.org>
Description:
 ocamlweb   - Literate programming tool for Objective Caml
Closes: 776643
Changes:
 ocamlweb (1.39-2) unstable; urgency=medium
 .
   * Team upload.
   * Make the build reproducible (Closes: #776643). Thanks to Chris Lamb
     for the patch.
Checksums-Sha1:
 961dd5e9cfae32a39b2973558db17e0d613e9dc8 2105 ocamlweb_1.39-2.dsc
 3981e0ef3b1056c40028ab1b98f5aed2ea77d935 8252 ocamlweb_1.39-2.debian.tar.xz
 4c4c5262c2e046f303b591fdaf9e784c2f61ca58 87102 ocamlweb_1.39-2_all.deb
Checksums-Sha256:
 56cafcb9204b444c3ac334aff70b6ee05e18590a413ec9a603ff941afe870422 2105 ocamlweb_1.39-2.dsc
 bd5d9699f760c2b8e752e63a7a08ff0705e413c81208f22ea644d4ed5ccd01ea 8252 ocamlweb_1.39-2.debian.tar.xz
 69004bed115fea312d3a76a56bf19e68aba6b7a9ad64d240b5779e66abbdb512 87102 ocamlweb_1.39-2_all.deb
Files:
 732928a5e17dc1143a2a91218b16f40e 2105 ocaml optional ocamlweb_1.39-2.dsc
 dd24fdc539da52abd59f11c2dee81f86 8252 ocaml optional ocamlweb_1.39-2.debian.tar.xz
 a6c1d419e23382a6c76f5fea3b7b774c 87102 ocaml optional ocamlweb_1.39-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVqLBQAAoJEDO+GgqMLtj/v5gQANz/w9KZD+SlbaFMaqMIlAdU
0+CQk9w7urmamDYXp7m5DKi1W78HKgoccUwiZ04X/1rwrWl5tmLluy1rAPormXT5
2u2+XbHVUTXXaywqUmp1AUPp0X6W3dMRi/8u3gVme6rE/OhxKRtuudCVpDomtdB8
141G2CrnLWjTCf6B3uGo8JpcWNR0ajq7I57A3byjeUa5nyeNL7EongFEv3UXIdLQ
/ZY/eNZrGa+5FH2Y1ZCmR92tphsjJfz4Okqkq2K1UW6znNTL+P5EiIB60rpMXfxA
FIqM8RRE0rO4vmOLiLtEzVsvIZlQHeWIlH+nwKfOnfGNhl09GByRZbJJxSiqG5aF
ixiPlkBwb5rZn8SnnyK4pTpq2IdsnqY3ifPSLetHLAmWXKpeDdsUNWL+tIQXGKBN
XVgV6cxgLeIAHa2YW1mc05BywPg25tV/So0/yOJjDzo9sCQr183FRVzX8ymhYzH1
a68mRClqtPTLWSjAM0XyF7EVKqvWch4jzoXbbBcYcNmzO5I1S3U6Pn5M488FotQZ
G2UbRnLnakHYSwm085+9ccBUqTbHzjV2j1QqGplTZgBoC1g5qLT19XEtIlaQED9j
AdWT6r7pTloZuwhSuBqphxz3WyhKP31drSEEy0OuUfPoxAzlonCVDZz2yRnMwij/
BT65uQHk6K9dbfC2oE8i
=5cq0
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: