[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#975504: obs-studio: reproducible builds: Embeds date in appdata.xml file



Source: obs-studio
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

A date string that defaults to the current date is embedded in
/usr/share/metainfo/com.obsproject.Studio.appdata.xml, causing builds on
different days to not build reproducibly.

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/obs-studio.html
  21 	····<release·version="26.0.2+dfsg1-1"·date="2021-12-18"/>	21 	····<release·version="26.0.2+dfsg1-1"·date="2020-11-15"/>

This can be fixed by setting a value from the configure target that uses
SOURCE_DATE_EPOCH:

  https://reproducible-builds.org/docs/source-date-epoch/

The attached patch does this.


Alternately, it may be worth exploring patching
UI/xdg-data/CMakeLists.txt to support SOURCE_DATE_EPOCH and get the
support merged upstream.


Thanks for maintaining obs-studio!


live well,
  vagrant
From afafba3e2105ca188e1a2b14398d65014b5fc370 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 23 Nov 2020 01:58:40 +0000
Subject: [PATCH] debian/rules: Set APPDATA_RELEASE_DATE using the
 SOURCE_DATE_EPOCH variable to avoid embedding the current date in the
 /usr/share/metainfo/com.obsproject.Studio.appdata.xml file.

  https://reproducible-builds.org/docs/source-date-epoch/
---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 80a4ae9..e0b1c17 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,8 @@ override_dh_auto_configure:
 		-DUNIX_STRUCTURE=TRUE \
 		-DDISABLE_UPDATE_MODULE=TRUE \
 		-DBUILD_CAPTIONS=ON \
-		-DOBS_VERSION_OVERRIDE=${DEB_VERSION}
+		-DOBS_VERSION_OVERRIDE=${DEB_VERSION} \
+		-DAPPDATA_RELEASE_DATE=$(shell date --utc --date=@$${SOURCE_DATE_EPOCH} +'%Y-%m-%d') \
 
 execute_after_dh_auto_build:
 	rst2man debian/obs.rst > debian/obs.1
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


Reply to: