[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#508114: jack-a-c-k: Patch not a total fix



Hi.

The sun is rising where I am, and I am tired, so I will be a little brief. I tested your alpha patch, and it does not fix all the problems. Line 972 of client.c still has the same problem for me: if(ap) is still a va_list that is being treated improperly.

I'm CC:ing my AM (Steffen) so he knows what I'm up to!

Is it adequate, do you think, to test if &ap == NULL? I am falling asleep so take it as a senseless suggestion.

I'm borrowing an Alpha shell from friendly folks on #gentoo-alpha so I can test there.

Here is the compile log to show it:

/bin/sh ../libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I.. -I../config -I.. -I.. -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -Wall -g -O2 -g -Wall -O2 -DJACK_LOCATION=\"/usr/bin\" -I../config -I.. -I.. -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -Wall -g -O2 -g -Wall -O2 -c -o libjack_la-client.lo `test -f 'client.c' || echo './'`client.c cc -DHAVE_CONFIG_H -I. -I.. -I../config -I.. -I.. -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -Wall -g -O2 -g -Wall -O2 -DJACK_LOCATION=\"/usr/bin\" -I../config -I.. -I.. -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -Wall -g -O2 -g -Wall -O2 -c client.c -fPIC -DPIC -o .libs/libjack_la-client.o
In file included from ../config/sysdeps/atomicity.h:20,
                 from ../jack/internal.h:73,
                 from client.c:40:
../config/cpu/generic/atomicity.h:23:2: warning: #warning "stub atomicity functions are not atomic on this platform"
In file included from ../config/sysdeps/cycles.h:24,
                 from client.c:58:
../config/cpu/generic/cycles.h:25:2: warning: #warning You are compiling JACK on a platform for which jack/config/sysdep/cycles.h needs work
client.c: In function 'jack_client_open_aux':
client.c:972: error: used struct type value where scalar is required
make: *** [libjack_la-client.lo] Error 1

-- Asheesh.

--
Higher education helps your earning capacity.  Ask any college professor.



Reply to: