[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: LibreOffice (code) extensions broken on mips64el/riscv64 (was: Re: unbreaking LibreOffices tests on at least release architectures)





Am 10.07.23 um 18:01 schrieb Rene Engelhard:
For both the mips64el and mipsel(!) chroots.

This means "bundled" extensions *SEEMS TO* work, those to be installed from .oxt apparently not... The question really is whether they actually do work or whether it's just a wrong positive display.

> So ignoring this test failure is a no-go either since libreoffice- lightproof-hu et al. (which is that lightproof-hu-1-6-4.oxt) is a thing in Debian, too.

There is some mechanism in place in debian/rules to ignore this error but I don't really like it.


Using that one to disable Java and python and using --disable-extensions (and via debian/rules logic patching out the extension test[1] in smoketest) "the rest" passes

[1]
diff --git a/rules b/rules
index 1835aafb..fa5e945a 100755
--- a/rules
+++ b/rules
@@ -116,6 +116,9 @@ ENABLE_GUI=y

 ifeq ($(filter nopython,$(DEB_BUILD_PROFILES)),)
 ENABLE_PYTHON=y
+ifeq "$(DEB_HOST_ARCH)" "mips64el"
+       ENABLE_PYTHON=n
+endif
 ifeq "$(ENABLE_PYTHON)" "y"
   CONFIGURE_FLAGS += --enable-python=system
   ENABLE_SCRIPT_PROVIDER_PYTHON=y
@@ -142,6 +145,9 @@ endif
 BUILD_ONLY_EN_US=n
 ifeq ($(filter nojava,$(DEB_BUILD_PROFILES)),)
   ENABLE_JAVA=y
+  ifeq "$(DEB_HOST_ARCH)" "mips64el"
+       ENABLE_JAVA=n
+  endif
   ifeq "$(ENABLE_JAVA)" "y"
     JDK=default
     include /usr/share/java/java_defaults.mk
@@ -611,7 +617,7 @@ OOO_JAVA_ARCHS = $(OOO_ARCHS)
 endif
 $(eval $(call gen_no_archs,OOO_JAVA_ARCHS))

-OOO_ARCH_DEP_EXTENSIONS_ARCHS := $(OOO_ARCHS)
+OOO_ARCH_DEP_EXTENSIONS_ARCHS := $(filter-out mips64el,$(OOO_ARCHS))
 OOO_EXTENSIONS_ARCHS := $(OOO_ARCH_DEP_EXTENSIONS_ARCHS)

 OOO_BASE_ARCHS := $(OOO_JAVA_ARCHS)

together with

https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/rules#L641 ff. https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/rules#L2272 /
https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/blob/master/rules#L2384

but I don't really like that, since this opens pandoras box for disabling stuff here and there for failing stuff (and my crystall ball says it will never be fixed since "the pressure" to do so is gone since "it works")...

Can someone with root on a mips(64)el/riscv64 (and LO installed) try whether

1.

$ apt install libreoffice-core
$ apt install libreoffice-java-common ure-java (just in case)
$ apt install libreoffice-smoketest-data
(or wget it and extract the .oxt from  the .deb)
$ cd /usr/lib/libreoffice/share/extensions
$ mkdir -p TestExtension && cd TestExtension
$ unzip /usr/share/libreoffice/TestExtension.oxt
(or the extracted .oxt)
$ unopkg list --bundled

for the text extension

FTR, that actually deosn't show here either as a bundled extension even on amd64.

I *assume* that it misses stuff needed for it...

Regards

René


Reply to: