Hello, Mathias!
It looks like you're basing your packaging work off of the packages I've created and made available; that's wonderful, and I'm glad they were a good starting point. However, I think it would be appropriate (at a minimum) to provide credit in d/copyright.
Here's the story: I was planning to package MakeMKV, so I checked for ITPs to see if there was anyone else working on it. Since there were none, I believed I was the first to try. I was almost done packaging, then I found your packages while searching for a resolution to a specific problem. Since my attempt wasn't very good, I took the best parts of both of ours and put them together into a better package. I fully intended to credit you at the end, but I forgot by the time I was ready to upload to put that in. I will now add a credit to d/copyright.
The d/rules file I created for the makemkv-bin package is quite hacky, and work should probably be done to get that into nicer shape if the package is going to be included in the archive.
Yes, I agree, but debian/rules etiquette isn't my forte, so I'm not sure of the best way to improve/rewrite it. Suggestions are always welcome.
The makemkv-oss package has a lot of vendored libraries. I've tried in the past to remove them, and found that some (like libmatroska) are sufficiently different from the versions in bullseye that they cannot be easily replaced with system libraries. (For instance, see this thread where the libmatroska issue was found: https://forum.makemkv.com/forum/viewtopic.php?p=111826) I foresee this as the largest hurdle to actually getting packages accepted into Debian.
Since this package is for sid/bookworm and not bullseye, the system libmatroska should be newer, and I haven't seen any significant problems with using it yet, though I admit I haven't thoroughly tested the finished package yet.
Is there a particular reason why you're using debhelper-compat version 12, rather than 13?
I'm not sure, I meant to use 13. I'll fix that as well.Mathias, thank you so much for both your original packaging and the help here. I really appreciate it, as I'm new to Debian packaging and not as familiar with the source code of MakeMKV as you seem to be. Now I can see the fact that I might not be the best maintainer of this package and there are others that could do a better job than me. Would you like to be co-maintainer of this package? You contributed the majority of the actual package contents and you seem to be a lot better at this than me.
-- Ben Westover
Attachment:
OpenPGP_0xC311C5F54E89B698.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature