On Thu, Feb 19, 2015 at 08:52:35PM (+0100), Tobias Frost wrote:
Ok, continuing... -> please document every change in d/changelog. For example, the change in the patch no-task-rel.patch is not documented (there are more, non mentioned changes on the patches) -> (for clarifaction of above: with cleanup patches I mean delete old patches no longer needed.) -> the upstream tarball is not identical with yours.
The original upstream tarball does not include taskwarrior test-suite, for this reason, we use GIT source tree.
-> You say "tasksh is now a separate project and no longer included in this package" -- does this need a NEWS.Debian file (refer to Developer Reference 6.3.4)
You are right, I've just fixed that.
-> do you really need tar-ignore in debian/source/options? When building with debuild, the build hangs after while: (However, in pbuilder it builds)
Yes! It's because I've not included python and git in BD (requirement for the test suite…) Michel also provide a patch in order to fix the generated binary locations (in the build env). It's now fixed, the package builds correctly in a sid clean schroot: $ curl http://pub.sebian.fr/pub/task_2.4.1%2Bdfsg-1_amd64-20150301-2253.build
(...) [ 98%] make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' make[4]: Nothing to be done for 'test/CMakeFiles/eval.t.dir/build'. make[4]: Leaving directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' /usr/bin/cmake -E cmake_progress_report /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/CMakeFiles 42 Built target variant_xor.t [100%] Built target eval.t /usr/bin/make -f test/CMakeFiles/test.dir/build.make test/CMakeFiles/test.dir/depend make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' cd /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tobi/workspace/deb/mentors/task/task-2.4.1 /home/tobi/workspace/deb/mentors/task/task-2.4.1/test /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test/CMakeFiles/test.dir/DependInfo.cmake --color= Scanning dependencies of target test make[4]: Leaving directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' /usr/bin/make -f test/CMakeFiles/test.dir/build.make test/CMakeFiles/test.dir/build make[4]: Entering directory '/home/tobi/workspace/deb/mentors/task/task-2.4.1/obj' cd /home/tobi/workspace/deb/mentors/task/task-2.4.1/obj/test && ./run_all --verbose # /home/tobi/workspace/deb/mentors/task/task-2.4.1/test/abbreviation.t Bottom line it does not look bad. However, please use this opportunity to create a state-of-the-art package and especially look at the DFSG change.
The DFSG change seems legit, according Jakub bug (737478)
Let me know what you think about the points.
I completely agree with your points, I've just fixed the package according your remarks and uploaded on mentors: http://mentors.debian.net/package/task http://mentors.debian.net/debian/pool/main/t/task/task_2.4.1+dfsg-1.dsc Or through the living GIT repository on collab-maint: https://anonscm.debian.org/cgit/collab-maint/task.git Thanks again for your reviews! Let me know if other things are not OK. Seb -- Sebastien Badia
Attachment:
signature.asc
Description: Digital signature